Date: Tue, 11 Aug 2026 16:45:49 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Greg Burd <greg@burd.me>, solai v <solai.cdac@gmail.com>,
	Nikita Malakhov <hukutoc@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: problems with toast.* reloptions
Message-ID: <anuYDQ4SG7maSSq4@nathan>
References: 
 <CAN-LCVOCk0hcqcu3Fw1LSVYecmQD1J26YNGuc=sybN=ds=WpPg@mail.gmail.com>
 <ah7jzDne6Ptu7fXs@nathan>
 <CAN-LCVPtuuhUyM4QJ81Ma+yU1kyA9GwgX31pGM6ix9L2zWafqQ@mail.gmail.com>
 <aihb_hMloqVDpbtw@nathan>
 <CAF0whuf=D3AncYxfuwK05_TFY+4nK8-teTYtoiu7Zp-pzVAPDQ@mail.gmail.com>
 <anT-1AlQKmXtcfrP@nathan>
 <anYM78YFDXHTA6xE@nathan>
 <896e1dbc-5ca1-4d9d-9f85-ae5a2ccac4f4@app.fastmail.com>
 <ann8mfCgOh_MYE0T@nathan>
 <CAA5RZ0urkERUBgbRi1AWiDJdXWo3yp=-5iO6bZ8d6Svp+XhZRQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0urkERUBgbRi1AWiDJdXWo3yp=-5iO6bZ8d6Svp+XhZRQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/anuYDQ4SG7maSSq4%40nathan>
Precedence: bulk

On Tue, Aug 11, 2026 at 09:53:53AM -0500, Sami Imseih wrote:
> I looked these patches while looking at potential cases for injection point
> conditional strings [0], which could allow for better autovacuum testing,
> particularly for the case being discussed here.

Thanks for reviewing.

> 1/ Instead of setting toast_vacuum_params.* inside each branch, it reads
> cleaner to set toast_vacuum_params.* after params.* is done, and this
> way you only set   toast_vacuum_params.*once. For example, in
> index_cleanup:

Done in v8 [0].

> 2/ A couple of comment tweaks in merge_autovac_opts()

I don't think these changes apply to v8, except for perhaps the "NB" one,
which I expanded a bit.

[0] https://postgr.es/m/anuXd35G8WLTUaBR%40nathan

-- 
nathan