Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wzdL3-0048Fy-2j for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Aug 2026 16:52:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wzdL2-003R4u-1b for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Aug 2026 16:52:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wzdL2-003R4m-0h for pgsql-hackers@lists.postgresql.org; Thu, 27 Aug 2026 16:52:28 +0000 Received: from mail-qv1-xf33.google.com ([2607:f8b0:4864:20::f33]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wzdL0-00000002iLL-19mZ for pgsql-hackers@postgresql.org; Thu, 27 Aug 2026 16:52:26 +0000 Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-90cca401c89so1374916d6.2 for ; Thu, 27 Aug 2026 09:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787849545; x=1788454345; darn=postgresql.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=j7DZlS/+IxG0PY0djYYgMhCQfTVyqHJHOCCq09TN9ns=; b=XofA6CwCD3BP5kD7QXXTbH9/QkP1uyY6Tuxu+7dDsbF6ZiY/aHKuZ7QandJVNIXAgH xPFWgb142seMbPEjoXJPZdbWf86V9OAOt+Q/E0onporodIDQ+ZE5aihb7enXZhPnZsKM gjvEBn1rwiROJs8dAgIpbhummK8ONCN3ZjtG+mpmpDmGZZa51GiU0TR5QFJyJwaL8dUh qPI+NFQ8c8iw896Kl8e/gPvWjAd+NnFrq+ZyBQ13sZbHRb0zVXQ5o9emur1c354jB0s+ jeyeoJ8Y9ZrSkaJzjI4wG69Pm5a/WX9OTof8q0td43OoJz22zmi5rITAcHf8UKH/E7w6 Ig2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787849545; x=1788454345; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=j7DZlS/+IxG0PY0djYYgMhCQfTVyqHJHOCCq09TN9ns=; b=ISPz2YPGeaynHbVBBFgOgbFl6CCUO4/Q81PNFt5CcyH9QkhwbD6K64Bk6pkCsjzTOC CrtM53UcY55u31gjR/TaTZuftCpx1yDq9BCuvTanfQGbGejYY8IRExq3OpOBTz+E6zRz ECXo94Uvli/vXPDpTXBDCHDPnoGQN/3hysBDNl42QrhRJG5y2YxOCdPv1hNSWjWzAzUh cyoekHzM6Wp2MMRXs2m30ClHMk/UdvxWK5vNpfzTtgmlOUwdyX1vPT+qpePLNLjzi3pi DHQMVWR763whe6edcpHdwZCGROL/CLJMX8S0lUJM1EomI4n1UyOd3GveirDOJMQY3LD6 Vrxw== X-Forwarded-Encrypted: i=1; AHgh+RqXcCpsh+7kAKGQqAkQC5roKGpm/bfPbwM/BvROUM4i91z1s6uobKGyDFe1o9Hy7292O26fQecyX6mmHf6x@postgresql.org X-Gm-Message-State: AFuF++lNJFAr6ldxLgUGx0/fHd6bHNmtHpUzp+y0+FWQYd4YgsaweYB4 RQ8P8shl7fjHtHyCZT7QxoNgBw1FIpx6ZbVrRc7wKF4jvOeXpqamN/YJ X-Gm-Gg: AR+sD11fxN/tb9YvpsRC9mNXoMrfi2oWzmr7ID9osjESJuQVL59BLnofiipsAUbCvb/ rB7/820iwKqyRxHZ7fKMVnQH9tcVl8kvDnlGMmu33hBetmf0cMGzxNSqwJiZX8nV74P3kn2DEJx 3BuX5x+1U0+1nOwclatqG6AgiMkZABTOmwkb5W1h2j9ucyxLrxm10PgXZNaYIMk9DUcCtpQbL3e 415yo8JBfZ4aTdKwzP07dBLn57VCdmxHKRrWPDxCTJz2LyikoeXXn0SJageTcSsy2uACBTXnLgD ufLFBcO971eLYbf+0xArITHx/ugSUqbztTAKXE0ruRf3xytO62xbScWPxjwJeAGmMBl5Ri595O2 0tOPUE1LbMbPwSNiLx9PrV/J91e6sdS0aOtU7a/+CGN9OhB49a4fcgceTaCEQUei1E4vWV7vwHU MfXbdBko5LPdgMI7toUxGmG9tTpdicR+xMWrhk7fU8Q4/BYQnOTteQck0vcTWQBO5ujBlMS+cnj d45NP4ZgGOHsLJvE8EbzYVecarT9GPIQfA6vnzLfb8WtXk39MK+XyZDhgZQGwr8bkAGZd+1HiXm GZJKo4o0hpDNO4o= X-Received: by 2002:a05:6214:c47:b0:90c:4e70:e5e0 with SMTP id 6a1803df08f44-90ce0c44f42mr7576676d6.6.1787849545263; Thu, 27 Aug 2026 09:52:25 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90cd73e3db3sm20857986d6.31.2026.08.27.09.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 09:52:24 -0700 (PDT) Date: Thu, 27 Aug 2026 11:52:22 -0500 From: Nathan Bossart To: Antonin Houska Cc: Chao Li , alvherre@kurilemu.de, Kirill Reshke , PostgreSQL-development Subject: Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes Message-ID: References: <70401.1778604528@localhost> <69CA7636-0359-42B6-B971-16A036698187@gmail.com> <134576.1778673638@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <134576.1778673638@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, May 13, 2026 at 02:00:38PM +0200, Antonin Houska wrote: > Chao Li wrote: > >> I am not sure whether we should change the behavior in PG19. Alvaro may have >> a better idea about that. But I agree that we can at least clarify the code >> comment and documentation. The attached patch attempts to do that. > > I meant just a comment that reminds developers that something needs to be > fixed, rather than defending the inconsistent behavior. Hm. Shouldn't the documentation be updated for v19 at least? -- nathan