Date: Thu, 27 Aug 2026 13:26:12 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de
Subject: REPACK (CONCURRENTLY) fails when replica identity index is dropped
Message-ID: <apCBRKCH8jwKiaSY@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/apCBRKCH8jwKiaSY%40nathan>
Precedence: bulk

I don't fully understand the mechanics of this one, but here is a
reproducer:

    CREATE TABLE t (a INT PRIMARY KEY, b INT, c TEXT);
    INSERT INTO t SELECT g, g, repeat('x', 1000) FROM generate_series(1, 1000000) g;
    CREATE UNIQUE INDEX i ON t (a);
    ALTER TABLE t REPLICA IDENTITY USING INDEX i;
    DROP INDEX i;
    REPACK (CONCURRENTLY) t;

    -- in a separate session, while REPACK is still running
    DELETE FROM t WHERE a = 1;

This produces the following ERROR from the REPACK command:

    ERROR:  incomplete delete info
    CONTEXT:  slot "pg_repack_34213", output plugin "pgrepack", in the change callback, associated LSN 0/A6CC1ED0
    REPACK decoding worker

I think this can be addressed by verifying the index exists in
check_concurrent_repack_requirements() and erroring out if it doesn't.

-- 
nathan