Date: Fri, 28 Aug 2026 08:14:17 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_stat_get_autovacuum_scores ignores the main table's
 reloptions for TOAST tables
Message-ID: <apGJqfd2xyAcUGKZ@nathan>
References: 
 <CAD21AoB1CJRVfCDh8qYuD3eueiygXxk7F3nybgjN0RZXSD-QUw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoB1CJRVfCDh8qYuD3eueiygXxk7F3nybgjN0RZXSD-QUw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/apGJqfd2xyAcUGKZ%40nathan>
Precedence: bulk

On Thu, Aug 27, 2026 at 03:42:23PM -0700, Masahiko Sawada wrote:
> I found that pg_get_autovacuum_scores reports wrong values for TOAST
> tables. In do_autovacuum(), we fall back to the main table's reloption
> when the TOAST table has no reloptions of its own, and
> table_recheck_autovac() does the same. However,
> pg_stat_get_autovacuum_scores() only calls extract_autovac_opts() and
> passes NULL when the TOAST table has none.
> 
> So the view computes the TOAST table's scores from rht eGUC defaults
> whenever the user sets autovacuum_* on the main table without setting
> the corresponding toast.* option. Here is a simple reproducer:

You're right.  I will work on a patch for this and get it fixed ASAP.

-- 
nathan