Date: Fri, 28 Aug 2026 14:52:09 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Antonin Houska <ah@cybertec.at>
Cc: Fujii Masao <masao.fujii@gmail.com>, pgsql-hackers@postgresql.org,
	alvherre@kurilemu.de
Subject: Re: REPACK (ANALYZE) within transaction block segfaults
Message-ID: <apHm6bHknXuEyElx@nathan>
References: <apBCEl4hBHlq0axm@nathan>
 <CAHGQGwEqN80ka_PY__DiPCu+S=h_7KgujnMEU38OU9C1zsGQpA@mail.gmail.com>
 <apCSd2NvvEJfBmVu@nathan>
 <49398.1787944525@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49398.1787944525@localhost>
Archived-At: <https://www.postgresql.org/message-id/apHm6bHknXuEyElx%40nathan>
Precedence: bulk

On Fri, Aug 28, 2026 at 09:15:25PM +0200, Antonin Houska wrote:
> I think there are just two different concepts (for historical reasons?):
> vacuum_rel() expects no active transaction on entry, while cluster_rel()
> handles transaction boundaries on its own.
> 
> Since REPACK (ANALYZE) is effectively VACUUM (FULL, ANALYZE), I'd prefer the
> same behavior, i.e. prohibiting execution both in a transaction block and in a
> function:

This is probably the way to go for v19.  As you note, the analogous VACUUM
command has long ERROR'd, and we could always look into removing this
restriction in the future.  I'd rather do it that way than ship an
incorrect fix in v19 that will be tougher to back out.

-- 
nathan