Date: Sat, 29 Aug 2026 02:41:03 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Zsolt Parragi <zsolt.parragi@percona.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Offline data checksum changes can cause incorrect checksum state
 on standbys
Message-ID: <apJGv8fffeUfSkCL@bdtpg>
References: <anwm6UPxoVS41QA2@bdtpg>
 <1C2BC974-44FA-487C-8A3B-8135A316A89B@yesql.se>
 <an8z8CJMa46FIxxn@bdtpg>
 <188A1307-1A92-45CA-9DBE-FB0962D3756E@yesql.se>
 <apEdrmkoNT6R9XyJ@bdtpg>
 <6370C439-408D-40F6-B956-55DF19FFE41C@yesql.se>
 <apFTwa68Qn0S0dIX@bdtpg>
 <CAN4CZFOv4CZfj0i1oesNhZV68zMN7SQtZPLJFEQip2dG=Pf-8Q@mail.gmail.com>
 <apGltAexjCkHPatS@bdtpg>
 <CAN4CZFMaw79Yd-sV=g=016xX3kpijD0WH3fPJEAkSusZwn7Avw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAN4CZFMaw79Yd-sV=g=016xX3kpijD0WH3fPJEAkSusZwn7Avw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/apJGv8fffeUfSkCL%40bdtpg>
Precedence: bulk

Hi,

On Fri, Aug 28, 2026 at 11:04:28AM -0500, Zsolt Parragi wrote:
> > > I'll try to look into what adding the two
> > > patches together looks like, but it most likely combines their size,
> > > as they improve the current master code in different ways.
> >
> > Thanks!
> 
> I looked into this,

Thanks!

> and I was right that if I add the pg_control
> changes to v4 it nearly doubles the size of the actual code changes
> from ~300 to ~550 lines, and fixes all the issues you reported

Yeah, that's what I expected, as v1 included those changes to handle these cases.

> while
> also keeping the existing suite of tests passing. The diff compared to
> v4 is relatively simple, so I don't think that would be an issue by
> itself,

Thanks! I don't see the patch attached. Would you mind sharing it?

> but it's another control version change.

Do you see the control version change as a concern?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com