Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x1U5W-005ECe-0h for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Sep 2026 19:24:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1x1U5U-007wea-33 for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Sep 2026 19:24:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x1U5U-007weJ-27 for pgsql-hackers@lists.postgresql.org; Tue, 01 Sep 2026 19:24:04 +0000 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1x1U5S-00000003Vzq-1cSG for pgsql-hackers@postgresql.org; Tue, 01 Sep 2026 19:24:03 +0000 Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-52ff7e275e0so1466201cf.1 for ; Tue, 01 Sep 2026 12:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788290641; x=1788895441; darn=postgresql.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=E9oMqwu9n1+QOGd4Sye+SBapXrrjAZTyb2KmB8wXLog=; b=DQqv70itIsxNuAXPk+gcaZY4yR173KEbovzz+9FSbJ793fj/D55Tw6vvmRQuEtE1c6 XOtDunn03PftMuHp5JwLa3dLpaR6tnky7K+zmw11y3SUxoANaWSfmiQw9HH8qSlr92I5 bXkZA6q0NbmsST+NqPUHeTwZ5BULFmU4yMVM6eQkj83DGIxaBTy+3VHG5DVDJsjlDG5Q jy2tpdHkZQfct2R6SAM9dDCVAu932LgtsKi76NXhbWiuZRXhLG0WRORtQtId6wp2OVdo HPANMwEbdZEaiTg0yIhqDEMDuPgOl5Q6wjKOcjWyZXSpQUJspVjHuO5wkOCe+5hQqKcS 6kDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788290641; x=1788895441; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E9oMqwu9n1+QOGd4Sye+SBapXrrjAZTyb2KmB8wXLog=; b=ViOUyX2X7qV9w37MTfzrST4W/hryZ69/FS1q5iyd/ZT4PhquIc+UgSn6L0cXHOBmK5 6WDAoj+AjIi7M+xRPEdKnfX8FxDcjwGs1JL57FQcYdb43thSDoDmcEnI3HCA2FmB+cy0 UFavVc/F8IZljZ8mnBIr2QzLmAV1qnkm7DcSwPQqmtiPvmFCDTJRd3M/MQ2VADjZwTSK 3AXCgrsEPJKiApTCJXsjEX3Qgh0oOCCMhTXzrfKnPIQAryBnEYXjC6XiREd2myyzVl7Q YzOYUzXFY2otfuRK9zMYgaABYiO9sIlUSEiravE7Zwsc5h+jsc0gv283ARRUZTvMv3Th 4gVw== X-Forwarded-Encrypted: i=1; AHgh+RoU0FxF8a5aYYRf62Cy/OnjvYzODG48sxeddGCHQ1tSRX6fZ4RTYsNjewaOXOgJfy5axPJ5EmwFuxO+lCwM@postgresql.org X-Gm-Message-State: AFuF++mXU8KK7TArVqBofIU3NUiMtOAC7ZjqqLQsYnB3C0eO2j7hrcrc wvt95FNjnuahPZEoMneqGYPPcMNRRe432LmVMFN7JS8U91IWl6JWi72r X-Gm-Gg: AR+sD126P0Ng5Z31yV7AaS5vkpqOQ48/Mq+SQrtMyQzT1vp59YFUhRLlyMbpPMyWMZJ eggqKgtnGdv1MAxZy+JLGaeCq2vJ/SatdKG/ZaXtFUjzHya4aY6HEc3BRWg8nvwEE5Z3PH3nB4d ceJ90gVUpR9ksJ2CobMdEV1UmNptS5jIqOvoATlR86Cw50e4c+TSlwWY1i69F/Y03j/giIkYgPm xnm+ApoOs7pLCJh24zNvnQwugsVqFhy47TkG0SKix9ApSqyi7EFNoxn2bX+aPskDAeFMShwZCF9 shdhpyJncDUIDGgodInjAmzpHq9hZgnP7GbVYhXH/YLfgqchbDPFIXfiD+0QpgEsJlefeROwTjR 0d6Uc7q6BWvUwdRC1NCKF/ixiZfX0EqxIaFNFV++VsFkFLTrk7hGksYVxB265S5fsmTPsjPPcZ3 RvdrScqylx3p8qzl/gvVX3k0Q2u7RWDXxvgl204ysWCKf2fmyqpzV7UsFeSdHMCtitfcmvolkDD YXuQ17xxG9Wa70yUIgivwkHSK6UUyNsG4/G7KxsAbxLTEdeaq7P2SiNwu+toq5RyKeqFAxPrxGn SmSDU53AB9F4l9BncdG0BZzBBg== X-Received: by 2002:a05:622a:4c0f:b0:52f:f546:c683 with SMTP id d75a77b69052e-53021d2af6fmr152772911cf.29.1788290641559; Tue, 01 Sep 2026 12:24:01 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-530331d9d83sm3506111cf.14.2026.09.01.12.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 12:24:00 -0700 (PDT) Date: Tue, 1 Sep 2026 14:23:58 -0500 From: Nathan Bossart To: Nazir Bilal Yavuz Cc: Greg Burd , Manni Wood , KAZAR Ayoub , Neil Conway , Andrew Dunstan , Shinya Kato , pgsql-hackers Subject: Re: Speed up COPY FROM text/CSV parsing using SIMD Message-ID: References: <43de48dc-701b-4735-881b-50bca6870f39@app.fastmail.com> <78e736c8-7f4e-46c2-9fcf-a6839e393d64@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Sep 01, 2026 at 11:17:03AM +0300, Nazir Bilal Yavuz wrote: > I re-checked the patch and the fix LGTM. My only comment is adding the > reproducer as a test case. Committed, thanks for looking. I'm concerned about portability and encoding issues with such a test, so I didn't add it yet. But I'm not opposed to adding a test along these lines as a separate effort. -- nathan