Date: Tue, 1 Sep 2026 16:29:08 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Sami Imseih <samimseih@gmail.com>,
	Corey Huinker <corey.huinker@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
Message-ID: <apdDpCj4zdw9vPPF@nathan>
References: <abh63Ro7XBvik6MD@paquier.xyz>
 <abiJtpb6FsluRpGk@nathan>
 <abiMCYxA5JI5T57P@paquier.xyz>
 <CADkLM=dc1P231z9X1-PgFsu6P+Bft4K9eE+nT7=zeX=_7YBuXQ@mail.gmail.com>
 <ablksYjpJLwwVmm5@nathan>
 <abls1l0aNZMRu33u@nathan>
 <abmCfOljRb_CbYu0@nathan>
 <apQ9nvLW_zFdarYd@nathan>
 <CAA5RZ0s1s0Qan2eiJLx=_5UpWtt-sUK8tbLN763qcLriWSrn2Q@mail.gmail.com>
 <apUSNL7IJIGYbNDl@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <apUSNL7IJIGYbNDl@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/apdDpCj4zdw9vPPF%40nathan>
Precedence: bulk

On Mon, Aug 31, 2026 at 02:33:40PM +0900, Michael Paquier wrote:
> On Sun, Aug 30, 2026 at 07:21:07PM -0500, Sami Imseih wrote:
>>> Claude advises me that removing the redundant filter clause was a mistake.
>>> See the attached patch.
>> 
>> Yes, that was a miss. I did a quick confirmation of the execution plans
>> with and without the patch and the change LGTM.
> 
> The extra time taken would really hurt when retrieving statistics.
> There may be an argument in simply reverting 4b5ba0c4ca52, as one of
> the reasons for it was to remove the qual you are re-adding, but I
> cannot get excited about using two sets of catalog names for tablename
> and spcname vs a single OID array approach in the long run.

Committed, thanks for reviewing.

-- 
nathan