Date: Wed, 2 Sep 2026 09:24:29 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Subject: Re: postgresql.conf.sample tab width
Message-ID: <apgxnR4jPKbiI4Iw@nathan>
References: <aReNUKdMgKxLqmq7@nathan>
 <3230808.1763151915@sss.pgh.pa.us>
 <aRefX8JOs_3VbErE@nathan>
 <3238135.1763156048@sss.pgh.pa.us>
 <aRehOVyEMFIxl5rE@nathan>
 <aRtugij0CQTbpmIx@nathan>
 <EE0918D4-F05C-4047-910C-F0DED136ADE7@gmail.com>
 <aRyf9XOgRhHn-AiO@nathan>
 <apRezMywHRuR5h-6@nathan>
 <41771CC8-C51B-48E2-A37A-F79AEF88998A@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <41771CC8-C51B-48E2-A37A-F79AEF88998A@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/apgxnR4jPKbiI4Iw%40nathan>
Precedence: bulk

On Tue, Sep 01, 2026 at 10:04:03AM +0800, Chao Li wrote:
> On Aug 31, 2026, at 00:48, Nathan Bossart <nathandbossart@gmail.com> wrote:
>> I noticed that initdb still adds tabs to postgresql.conf.  Here is a patch
>> to fix that, which simplifies replace_guc_value() a bit.
> 
> The patch looks good to me. I tried generating a postgresql.conf with the
> patch and diff-ing it against one generated without the patch. The
> differences are just tabs vs. spaces between values and trailing comments
> on some lines.

Committed, thanks for looking.

-- 
nathan