Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 3 Sep 2026 14:15:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Subject: Re: Report index currently being vacuumed in pg_stat_progress_vacuum
Message-ID: <apkCcttASAC6d6J8@paquier.xyz>
References: 
 <CALj2ACU3+seeZKAsH=d_LpVEVRfafnvqDmj3czFf1daOTbXVyw@mail.gmail.com>
 <CAA5RZ0t2vArQ3EpWSqSQekROuKeaonvgOz=Czkp4Q0tS_krscQ@mail.gmail.com>
 <CAA5RZ0sw8ZuAYt+bJ_VvJvcHVKe+=1tstC7oqAqUye9_3Ta6gg@mail.gmail.com>
 <CALj2ACXhLVJh0OeN5W61_UvhyBxH3k98ffXhnRPYr8NsNbMZSw@mail.gmail.com>
 <an6P_WQNCM4P843q@paquier.xyz>
 <CAA5RZ0tbkiEpD0ZBL+ACKO8o5mDkZmZq0PAdABqQt2nNr8MKjQ@mail.gmail.com>
 <CALj2ACWWf-zDXpXDZf5fscPq_fwVY=NX+7w4JcObcgXuY9=h+Q@mail.gmail.com>
 <aoeJa9Ap4_MyFX3_@paquier.xyz>
 <CALj2ACX-49BrUTXaM3HeWVaZr+zGkbcLNJcrQ_dgjYF9AtW-kg@mail.gmail.com>
 <CALj2ACVYtmj=P4u1cBO+MwHFYQw_wzVxhtcV1WWrELbSOvuuzg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VsytKOFATuVsqQ2J"
Content-Disposition: inline
In-Reply-To: 
 <CALj2ACVYtmj=P4u1cBO+MwHFYQw_wzVxhtcV1WWrELbSOvuuzg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/apkCcttASAC6d6J8%40paquier.xyz>
Precedence: bulk

--VsytKOFATuVsqQ2J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Sep 02, 2026 at 07:23:00PM -0700, Bharath Rupireddy wrote:
> Thanks Michael for the off-list chat. I agree that emitting leader_pid
> via the vacuum progress report is information bloat, since one can
> easily identify the workers for a given leader by looking at the
> database OID and relation name, and if needed, can also join with
> pg_stat_activity.leader_pid. So, I removed leader_pid in the 0001
> patch.

Full disclosure.  I have discussed this patch set a bit with Bharath.
The discussion can be summed up like:
- leader_pid in the progress view with a JOIN to pg_stat_activity
feels like bloating the view with duplicated information.
- The database OID, the relation OID and the index OID gain in
visibility by being specified in the lines for the workers.  Note: it
looks like we are doing so based on your output posted upthread,
missed that during our discussion, initially.
- The two new fields for total index blocks and index blocks processed
make more sense than trying to reuse the heap attributes because a
leader may do itself some of the cleanup.  Multiple passes are less
likely lately, but could still be possible, and we want to know where
the leader is at for the heap part while working on the indexes.

Reading through v5-0001 and v5-0002, it looks like all these check
boxes are ticked.  In terms of review clarity, splitting both patches
slightly helps, but I'd rather merge both things together at the end:
the first patch gains a lot in value thanks to the second patch where
the two block aggregates are added.

Perhaps I am missing something else?  In this case, please feel free
to overwrite my words..
--
Michael

--VsytKOFATuVsqQ2J
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmqZAnIACgkQnvQgOdby
QH1VjA//axizXciHPZbdb3FOLJkKx/XYzCXCyoOzZu5kdfsyTn+hcwXzACRinQpq
p/1gbOV5OOvu8UZexqkPEYnwiTw786GWdawDqtXRNV8Ke0SNHFBNs54bCnb4fEhn
TgXzZydXKA1mXIU2iMwbMP9mATsBa9KmtN4kGpnKwqroEPKtJ+2cKu9J44v91bPV
Q+v9VyPHkI8nT9a5lB2uTqta53XmLdlqKNl+fzpfHUpB+au/t8jsgqFlkEmlUfCV
QfLaXB0uMZtCqlFYRoiRfruwDS+2vN7RQcYD9V4uuWjzsdPnBB6pNcpeiHlzy6rB
j0/DA1iYnDgp4oFWylV90pjCcIzlQKpyfxsG62m8fehx0BgiwnoGQWSQ401TjygH
Olg+W9LCW7X6K56Cn3Uh++q/Eqm67oH5r1quvQeWRKGn7wo6JnIm5+AtbSgJ1QWN
DD0ezhkxFlOECM+l2FP0Eb6pOqsJf4Y+rc1BWRP3Fd3eEEF76pa0NyodGq1elYgt
OY3sdcGYLm1Ujx3HvKp7+RKmt3GuzxA2I3XFAAzSq9aIXwUMPaOPrcJWlGi9TjU8
hvc0sYUhGJ+P+lV5CK8BnoXpiEDlDR1tubwX3bEnncJ6Eju9Uj+7hpxuBjNEDlBn
gHmjr92yweruRSvXwlhIOoN0AdTFOMeMleI7cqSfu69zJNkdE/Q=
=3DTS
-----END PGP SIGNATURE-----

--VsytKOFATuVsqQ2J--