Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x4KAa-0074Xn-2r for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Sep 2026 15:25:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1x4KAZ-00FzRX-2p for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Sep 2026 15:25:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x4KAY-00FzRC-32 for pgsql-hackers@lists.postgresql.org; Wed, 09 Sep 2026 15:25:03 +0000 Received: from flow-a3-smtp.messagingengine.com ([103.168.172.138]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x4KAU-00000003mrA-1gNk for pgsql-hackers@lists.postgresql.org; Wed, 09 Sep 2026 15:25:02 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailflow.phl.internal (Postfix) with ESMTP id 090151380086; Wed, 9 Sep 2026 11:24:55 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Wed, 09 Sep 2026 11:24:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm2; t=1788967495; x= 1788974695; bh=2rtDbjLQq8gcrhYba0fFOdyoUSQg4cBzs6n1kdgfSl4=; b=H eDqI3Y42gY3hgeghTbhh/k60JQr7DKwl6gWHot+rBIUPad6/prVYvncLw843raUG CjlTHfk84R+RNaJkt2h8wohkBuGyi/cCrk7s9/K3WgW452gHI4SOYpAAORDzj4Sl toZsbOQxoPly3MzPb31ectCCrtg0eWJ9Ljw+fAjgsWlyNIp5cinjSCYnDME5eCSX CqNWurQM43jOI9xkgsSPW4LfPumopyIEOX6AISwSFUXKI6ZLEXcU/iGJMs9vsZ6s oEj22AMUpf7bHo8ikOjBR9cuDxQhHel/aa29u3yV5I9U9qrdA82x9oojEQafYDpr BoTJcHiUmQEYegeLCUspg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1788967495; x=1788974695; bh=2 rtDbjLQq8gcrhYba0fFOdyoUSQg4cBzs6n1kdgfSl4=; b=S8+kG5sO6l+Jbr9br iC31MSJBysk7CFaNhs2CEK2Dp9CW+qvEJ/UxfcEOOgiwk/zXT+22UovcK2E0m5pl 7FlTtuuzZwJewoA8W4dkJ1k8Rf9LkZAZKZP7NvsZlOg8UJD96Yj1HJvKU0JP0Glf I1B9nXGnI+nktRHD/n5MIYjEhzKdeUL53opA0HgN0mHVNz/0oqF/VHi8k4I1RkaO 4zgYXH22GQmecg40/FUYiXLdO0J8F0zMwYYLF+ttVAwLK2o0CJDHrsr64sA31Qtk EI6a+BY8KEHU+crLoRsDKDE1qqkWU8nFSgp/mWEOTkB2nmTiPKVMKzEFk4s3fJui GrMpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGqtBM+WhKCu24x+yBL7EOicsURCQTGMp1U8fTYa/dvJqTWP1oZByLOqmbd87OhhX UFZRPe4oBds68g+kB1uhRtIANKyg5MNdPUOGYX+EFI31u5Iw8N4+4UYUEgZHxzXTyvHDbA Fasn/VB7SXmiHjhnqXpeivonCMTGMJIcQOxh3Q37D/e79ziAAuSYFLQPDdwPa7q5rko1RC nsjxSYFuteKNphRibR/92+ND4KryiekGCBNQDKSKeb1+3TfYf8EXbPJO4EI3WSP4qdfDe9 dPiVQz8LRvYTVHvuomA+PejOxuMfz8AUVbUVkNSBKCRett3MoMdDOPLPQgW86Tcjlna3PA yURzMZPC2kVMGjN8sfDsTt/bE9E2+kl4BC2hM1DT6LZPWLpmhxred1F5L4wRM9zP5PEAXj iC3ibezcBUNCY/KmVNfdGe+XSNFBRB0FtuqtavCIkuca/4fZP9Tfp07Uh/whIeyuN1X+9q krIb1KYL1f6NfMguQr2IMRfUwf/CmeDgYhqhJ3jUhY8dam/krAv2+ewNQiPFhhDQDs40pQ qntOohqptqV21+r1ecN/Vz9ISYEqaR0lSHmDRMvyiSAJBd+8ZP08la0TMQFswpvMTpt6pc +FfX3te7AyDW7xfOTn4FRdpXfFcrS/0kZQ3yl0mSfFKGHAeFGF9xmaHflMNQ X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Sep 2026 11:24:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1788967491; bh=8+TEmjwYwP1H43mOkqGlYFhvCPkKGJeIma9Bmd+ZcO4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ZqnLPB+eTK3FT/VNh0k76F1RPo+YZ7HZxjdBxWz2mXdf2sYqOkCds2skx/YK7FPEA Aw3UM42bjZOZvcjffB7g+qJZ253CJUPF86MDrNYAeipkyqDq8ySfpaZ41oB1jVuQ1T 1a2uuRjXCbJ2mA2qwm6tHyaQcu/9KuRMI0kt/a084SiS49LxLAcaecwLGpN1EZOK6t TiqGuPp32Sn0ghX/H0KnDMNXqpi+OWn/hcD/blbsWwSiRp/gmyGj+EIDT/hFj8opLy yvsjMSxSkW375n54uBbNvyFn3Y3JJtNGqam4SKhu4bC80I47CGj8xIfgOx18QszpRU mm3nJaOxeBWww== Received: by ida.kurilemu.internal (Postfix, from userid 1000) id 35AD3B00039; Wed, 09 Sep 2026 17:24:51 +0200 (CEST) Date: Wed, 9 Sep 2026 17:24:51 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Sami Imseih Cc: Xuneng Zhou , Postgres hackers Subject: Re: Reject WAIT FOR earlier in transaction-snapshot mode Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, Not critically important but note that the PopActiveSnapshot and InvalidateCatalogSnapshot call and the comment about "giving up if there is still an active or registered snapshot" have a close relationship; I think it would make sense to keep them together. I would add your new test-and-ereport just before the PopActiveSnapshot() call, to avoid breaking that. Cheers -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)