Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1x57of-007dos-37
	for pgsql-hackers@arkaria.postgresql.org;
	Fri, 11 Sep 2026 20:25:45 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1x57oe-000dWX-38
	for pgsql-hackers@arkaria.postgresql.org;
	Fri, 11 Sep 2026 20:25:44 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <nathandbossart@gmail.com>)
	id 1x57oe-000dWA-24
	for pgsql-hackers@lists.postgresql.org;
	Fri, 11 Sep 2026 20:25:44 +0000
Received: from mail-qk2-x10.google.com ([2607:f8b0:4864:34::10])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.98.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1x57oc-00000005CC6-2aXW
	for pgsql-hackers@postgresql.org;
	Fri, 11 Sep 2026 20:25:43 +0000
Received: by mail-qk2-x10.google.com with SMTP id
 af79cd13be357-939109fafd6so17671185a.3
        for <pgsql-hackers@postgresql.org>;
 Fri, 11 Sep 2026 13:25:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20251104; t=1789158341; x=1789763141;
 darn=postgresql.org;
        h=in-reply-to:content-disposition:content-type:mime-version
         :references:message-id:subject:cc:to:from:date:from:to:cc:subject
         :date:message-id:reply-to:content-type;
        bh=8upsL/iUN2NkKDQbfjPWS0BOEXMwsFpvrpy7mMw9z9Y=;
        b=XAxwq+YN9wsmKvEDlZ1Ec3egc+9+QwAXE6lcB5rBDQegs5ZSrm7naj9H5B/DXuTz2M
         sNUXweS+XNdY1eaLO1b4fh5+jM393reQsRTdMuqqZnUd/jREVTrX3FHAnLBNTMc9La7Q
         fy4uixgCkmTgzf3i5X6+QyzJKFw4gI7hgTLiik8m7Szm5cMkkuQh4xnqKNMPS/IUnBlC
         jiHsPK93lypzIsgWgVDW2k7ozg94EVzix8oA37Un8dhcHyL3yybPze19UVyLyuYyRG4L
         JF5RVoNGWQnjF7c8T5A63BKnsaXnFyt6H1Ho44rab0/NmnEaBjdfBlBcimBnitU8omLa
         XXng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1789158341; x=1789763141;
        h=in-reply-to:content-disposition:content-type:mime-version
         :references:message-id:subject:cc:to:from:date:x-gm-gg
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to
         :content-type;
        bh=8upsL/iUN2NkKDQbfjPWS0BOEXMwsFpvrpy7mMw9z9Y=;
        b=UztZGNVFP4y/FmMRzLPHGr2rPJJnHJL/7fpLK5gjx+DtuEgm9ogPgM585bum7y2WVL
         J/qgCoMwm8z4YHvbAGjDf5JNj27WuxMkQY304xZC6cDUmMR1UuMDuUanwXQDT5zj9pNk
         IBqqSDOhRhB+otRcETnC4S2iJRYSz/lda7tEQf2seZ9YDvWqJ4OpLr97PN6leSfPipHI
         jCFf8S0PhBRBOdB/MCDiqv4NhIGII/ffqZIoEQb7xNZ9lQ5XxqLbBwpQBPeO0ZTuse+w
         EmXItCFUvcUsZgoNFbXeVPcdqM4JuRZObIPP1eLE9Hxc8GpBsOO+8xStKSKtn1ihAGcI
         YSrg==
X-Forwarded-Encrypted: i=1;
 AKwUvBzVI1oE8EMNTi6DY+Wh1Bvu/rKmnCAct21tu6DdSYyTyNh7sEioZ1b5J9/5/gJRY84XghR3s/7bVe0UBwTq@postgresql.org
X-Gm-Message-State: AFuF++mgSkOZUtE9APa95apLwYKJzfQudpy9bEbOaZ7u9N1xy8pOqBhC
	atCiBO252ybq9zSErfv8d4QFlxLPeGmaIFJTfZt+d/frIoXUynSciHIg
X-Gm-Gg: AYBFou09lu2QGkEkoRyamFGl9b89/DTCASmqb/4Dg6e+LOclL4eQVC8P8VEyT28o6br
	TQT5dhjDzCaK2wU12wt8U3EHRIHEYpYjPl/aw0lxGOqgAHbptj59aSrqmTd70hVIVmcF1elE68Q
	WywbPBNGnWTaZlhu+G2RCCt9iwBPL//TsEYgRQkh4avXL40PpNp9caj2DoiTuTCL/MoebCqLtMJ
	uai+rj5//b4IDIP1zam9ZIXuezrh4Om4cy44t45gMV42swULR4Ae4HM/tEzxJLRxe+A8Fq5NfAA
	cIMT32WSFdBpMHV84ttCwUecnXxVVRE4otoxKKQhLETkWbFMGb7glj+GP5oSdi6t8I2J0m52R2X
	/J2+K8uI9IkJwHHzcSOX1APJ3/YD/gPHiROD2tB91nPlq+aQp4G4KXs+8t61hDobrhoP5NitjHg
	wIU1a7mD7zEIdW2jwJ5EQwrU+BtPNw+7cm7HXXA7lWnOCm/OJ/cZYKuCGHiPIv20tdkULrivwmh
	A76LJ6aBlST64ae2UbUzQrkprKlJFh/Mvbzjy/W4ngybtL/lhfEfpyKxJgenMUXNJs5qdCy2SqM
	3qavfXZFWG3U7Six2Hgv1uhn6Q==
X-Received: by 2002:a05:620a:28d5:b0:939:6dea:ce79 with SMTP id
 af79cd13be357-939ea1f793amr820823585a.47.1789158340844;
        Fri, 11 Sep 2026 13:25:40 -0700 (PDT)
Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net.
 [162.195.168.172])
        by smtp.gmail.com with ESMTPSA id
 af79cd13be357-939e807eba7sm324745285a.29.2026.09.11.13.25.39
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 11 Sep 2026 13:25:40 -0700 (PDT)
Date: Fri, 11 Sep 2026 15:25:37 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: solai v <solai.cdac@gmail.com>
Cc: Sehrope Sarkuni <sehrope@jackdb.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Fix getopt_long() argument handling and add tests
Message-ID: <aqRjwZ3-sanACclM@nathan>
References: 
 <CAH7T-arxDuVCSkorO=k7+M-_JV0JFzMpN_EtKMyD2K0RDqZ2OA@mail.gmail.com>
 <aps-8xDMYZfVQ5rQ@nathan>
 <CAF0whudL-=b+z7u0JVC3PD_h8-uVxFS3HpgiJvdJph7y-DrBmg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAF0whudL-=b+z7u0JVC3PD_h8-uVxFS3HpgiJvdJph7y-DrBmg@mail.gmail.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/aqRjwZ3-sanACclM%40nathan>
Precedence: bulk

On Thu, Sep 10, 2026 at 04:26:05PM +0530, solai v wrote:
> After applying both patches, both cases behaved correctly. And I ran
> the affected TAP tests and everything got passed. Also I reviewed the
> changes in src/port/getopt_long.c and the corresponding test
> additions. I did not find any issues with the v2 patches.
> The patch looks good to me.

Thanks for reviewing.  Committed.

-- 
nathan