Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x8y3p-00000001fJP-18w9 for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Sep 2026 10:49:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1x8y3o-0000000FHww-2SM1 for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Sep 2026 10:49:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x8y3n-0000000FHtO-2k6q for pgsql-hackers@lists.postgresql.org; Tue, 22 Sep 2026 10:49:16 +0000 Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x8y3i-00000000ebw-0VXd for pgsql-hackers@postgresql.org; Tue, 22 Sep 2026 10:49:14 +0000 Received: from phl-compute-07.internal (phl-compute-07.internal [10.202.2.47]) by mailfout.phl.internal (Postfix) with ESMTP id 9A2D3EC00F8; Tue, 22 Sep 2026 06:49:09 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Tue, 22 Sep 2026 06:49:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1790074149; x=1790160549; bh=+zCSUPKDIe +xCVYC7XNk8/b9GunUak5etXNxLl3n8yI=; b=X4t3Zu1hpfuluXXz9wsakuXliI jhq4cl01VUXhmF/wDZa5fA5Cl9o4g6S88nNyfR3Ixox/Rg1bA0DkBIr8LvyLvlbv vPdFhZqchwEkkdQYDNL2bHZRqcWe/6i77+mTZcAOq62VBGR9aBZiWfs2sRE2SS0p 5KSh2N/JAECUhCvZWkmGKOyxRHgcj6w9zI+HVn6daRuXIrmpPD4jZChKUaVNpLFI dFVDWoQ8/pM2p2gKxq5ALOMmb0X9BVwvSxkqZxYeJCfKHBFWq1XzY1A4zqtV1lXn VmYg1fsyJv5cUtvEuh+VIbZgXNXCMnoGPMTktbnj9XUWPVTBWuIXKjypa89w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1790074149; x=1790160549; bh=+zCSUPKDIe+xCVYC7XNk8/b9GunUak5etXN xLl3n8yI=; b=D9AEgCz7H2zyEAOdU1KxmNpQpBD1qBcChckzEx3JJ5lpW9p4Qjx 3SVdfu2I59Ldcim91jYwnuMhGjeND8bW9hStK+M+PKoGiFBwd8ZnJGqzEkZbXW70 0GcvgS+syLOrrahfAy2lMvc/tdW0k1wjTOt1r7Q002tx6mWumSTLDVlzNoD007Qb EbB1zNgTDy82nSHX638MjssiZXel/ydzlpST7/69rAb2b9ItUQFXHkY18JKg3tR9 GfJVmIyg1KO0UArds0fy2+quLd0K2Wu0omKwYT18QZy9KW3Ks89k73bXR+xGEf/M xj51z3QpGrq4peQUqC/XqzOeG2Nbrnl+dOA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTG04ijI5Ter26oVJHr6A5V/Qpc0Y2wJwIk6bkwR5gN3qULKuAXgo1I8K6gCyBwBa+ 7C6reVVVLJFcvG+nbSgKWrMmCnirXbL3/pw7qTsKqceD3tOuKChs6IMwP1iAmMXBZkV+tl Aqbstu5JPrbWWqkMsnb+jYlkThLw5R3GCs+wSw0jCLmCxvMFArycs5IyO5u1HT7iFmFbCD nogISAoc9mWOVeMcaM/YT8yBOkcUlMGUWfHQj0JsvRK2VmWw5ATo5tY9G6SRAEpSXwvoAP nQaiNFFB4SNgoR2t4M4AcZF0qDKRUhMih3vemXBh44S10aY9jkOG6sSDTxgDW7DoSoLso1 981duIWyMwW42TfB/Bb/L+gHUt6SRnJhGNw7r8SSwTdtT4BGJQRf4hBAekYxiB7nZdQblR 7p365ZGlHhZ19Cr5vuX1ow4zsRNw2f1dX/ESEOVXwVNkG475hZZyKsKT0CMecDWmYn0K19 AvNq4a2L3MRlirLs/q1B6CAzER34ZvxEqLnHFbeHm+PWUiMo9VoNVK+zk31VCcQahJD0Nu h9GQkrh986+6IHQehVqSXDnq1beSlgis8hYxrKPYZgS+qD1/pE0vPDOqgHI/YpJ9iCD8ga hGuJHFePxYZWOzqr8M5Yl8IeDmo2eeIQo6wTySbRrkabUf8sagDq4NtYgxpw X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Sep 2026 06:49:06 -0400 (EDT) Date: Tue, 22 Sep 2026 19:49:03 +0900 From: Michael Paquier To: Alexander Lakhin Cc: Tom Lane , Andres Freund , pgsql-hackers , Justin Pryzby Subject: Re: Internal error codes triggered by regression tests and user queries, take 2 Message-ID: References: <94ac928b-8370-4db5-ada5-579a9ebc089d@gmail.com> <697477.1787754418@sss.pgh.pa.us> <73eb724a-c1a3-456c-be12-0375d4556b67@gmail.com> <91a1b0ab-2c6c-4471-b7a4-ee8ee8aed64e@gmail.com> <126103.1788721678@sss.pgh.pa.us> <8343126e-11e5-48df-9f96-ea03a2b7d5ba@gmail.com> <7a9b3652-134c-4565-82ad-839035a3a382@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JCVlFBQHMfYEw6j8" Content-Disposition: inline In-Reply-To: <7a9b3652-134c-4565-82ad-839035a3a382@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --JCVlFBQHMfYEw6j8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Sep 12, 2026 at 02:00:00PM +0300, Alexander Lakhin wrote: > Please look at the attached v3-Define-...patch, where I think I addressed > all of your comments. The ACL bits were slightly puzzling because it's the first time I see this pattern in the code (following Tom's comment upthread also in tsvector), and I indeed get much better error messages: =# SELECT acldefault(E'\x80'::"char", 0); ERROR: 22021: invalid byte sequence for encoding "UTF8": 0x80 =# SELECT acldefault(chr(1)::"char", 10); ERROR: 22023: unrecognized object type abbreviation: "\001" The second query just showed nothing originally. For the typmods, %d is a better choice to me as the input is an integer. As a whole, that looks OK, so applied on HEAD. I did not look at 0002. -- Michael --JCVlFBQHMfYEw6j8 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmqyXR8ACgkQnvQgOdby QH0xxg//egIGVEXMkv2+SIEWa+hDs/+oCwBFU92XY2ZYh2MQgsOza+zGRhjogRwG w7KBzICfMpxAn6YJvIDgXXgB6NTC4+Jd4hcywAUydp8hBoMHMwQOLErkT9BwJDWD EI2Cl0D0ml93C5V+w0xBdU3BN8kn9TuE2tTXbfGA9TJt9XSshJNMjxdNqz4vWF/q nDV+k0+L9pOZiEGMidBAvemdskPOpmkH73VEUDuJrnT0n8rzRw5Fe0dgMA+hlPla FjlhPdAhkPv8GJ4oNA0QIl7FQgfR3t9D+3apVaqiRXEkz2ud20AfHrn+WMuBuXmo pFk+lofQ6FM6ty4/a/q2x/TfSF11Z+B/vSBSJngb8aoFTFdiFhUHGHPy//tr1xAz B02ZbOwVJmMMw5QO08pI8vwVm9jDbxSlK0TaBXB4Xc04Zq5feN68J3C5vDFVj7RI LyazwfpmyHrRiPIFcbRP5QsPXEmPmEmPWVBLflEwuJU+BQaTxGLnHgFMcWlIKrUQ A/fNPsNgTPXbZz0VF0T9K5hCjdK0IG4madNJnaOSWv7mgptGWkt/524nozsv25dC amx8nRuNymJyBHpnNBFIaE/hp0Wd2Ee9zE/sDbJYOmWBE+46Cxz6I5d85DZjWbhw HrrAPtvKQ0vE4aidZFxNNMp+QHUah1wAmhlfGuT1EH8NvNPnBo8= =gyS+ -----END PGP SIGNATURE----- --JCVlFBQHMfYEw6j8--