Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 29 Sep 2026 07:57:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Zsolt Parragi <zsolt.parragi@percona.com>
Cc: Nikolay Samokhvalov <nik@postgres.ai>,
	pgsql-hackers@lists.postgresql.org,
	Andrey Borodin <x4mmm@yandex-team.ru>
Subject: Re: injection_points: canceled or terminated waiters leak their wait
 slots
Message-ID: <arrw8isOSbfkK5Fd@paquier.xyz>
References: 
 <CAN4CZFO+KF=cc0-iEg28RhqRBp_fTs6D4b8b7D7DB-pGYP3Ccg@mail.gmail.com>
 <amAc853flInQAEI5@paquier.xyz>
 <CAN4CZFM5KGB0tuw8LA9jtbDzsf1qa+UxSzYUuCUJuB12ym6DHw@mail.gmail.com>
 <amBjKAJLyPR5hdlE@paquier.xyz>
 <amGpM1v-hhvVav3n@paquier.xyz>
 <088AB35D-0860-494A-A9CF-8B301543AA51@yandex-team.ru>
 <CAM527d8gNR9MW-BSC=DFm7aufx6P+_hALSVr-ML9Er0KpE9jjQ@mail.gmail.com>
 <CAN4CZFPsHwozYFFXKQof349L6AiHqoSrm+oSajKBrGdCpG-=Tg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="aQGiOMhPc6tAMehJ"
Content-Disposition: inline
In-Reply-To: 
 <CAN4CZFPsHwozYFFXKQof349L6AiHqoSrm+oSajKBrGdCpG-=Tg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/arrw8isOSbfkK5Fd%40paquier.xyz>
Precedence: bulk

--aQGiOMhPc6tAMehJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 28, 2026 at 10:12:37PM +0000, Zsolt Parragi wrote:
> I was able to reproduce the issue both on windows, and on linux by
> "patching" the server to reproduce the described behavior.

How exactly?

> The overall changes look good to me, it just needs some
> squashing/organizing to be a proper patchset.

TBH, I am not completely sure what you are proposing here.  v1-0001
=66rom Andrey and AI-generated-not-reviewed 0003 from Nikolay step on
each other with the latter patch requiring the former patch, in terms
of the way the last buffered error messages can be consumed, which
should be either something local to try_complete_step() or tracked by
IsoConnInfo.  I'm OK with the basic idea of having more predictible
output here, with some alternate outputs to make the CI happier on
Windows, let's just organize a bit the whole..

-       SELECT pg_terminate_backend(pid) FROM pg_stat_activity
+       SELECT pg_terminate_backend(pid, 180000) FROM pg_stat_activity

Avoiding hardcoded timeouts would be nice.  They are not liked on slow
machines.
--
Michael

--aQGiOMhPc6tAMehJ
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmq68PIACgkQnvQgOdby
QH3seQ//U4FolvK4bRQy7PXO8p4S/HTS4VL59D9Y0LCPsZP6Z1QFSNFSBeTLHpxq
qLCLaiLDECIk0g5SsO7sr8TqPkw8khomRZqseSr3Gzc8urhcDfow5LUzoK9xLVKc
xpGfvlEhTDjdszwkZNValcuLbXA5mrdNh4HSSHCdcVmelTCqMLMMJ5ZtI4HrIpYq
16SjrbMaJ34vviFtHTBeuKCVHcWq1Jxh1DIoyzdFtN5q5xbOsr5ESKR/hENXVm14
5hWWhZ1Pbl67parwixLLJjxoXJm5ANX3ZmksE7dOYKH79u9bKFvs6WPTLQNmoc9k
6o+uFXJO2Ks7DVijYmHoOY3KIM9VVshgfKuoDwNbu2VQYowB/UvXjBg8lysviSTq
0svXgffcFwrd4bcwlRJw4c1ZuBL0/Viu6ue7OjlUO1AgPylme2j31hRrl2aKFeq5
gXUqVO9Ft1YjT4xjkL1geVyepszbAwToJJC6IewfBeKhBThGGS+FCn+d92v+lzez
bx8RM/LtKbb8ahXxBYzA34YYRLnysBXCk/oleL69iW7tMQmT82S/3JV8wNEH2W+u
y0ZkN0E9Mp7T3G2JzU45aCs9MvyMDCiQrMlg3lY9IqCvz5dQB3y3QfRG5WDsMV2o
Sw6QAdJJ41rBRVlIFmeJIACUmN5FSSQlrBVgH7H+387d5V7DLRk=
=hEKC
-----END PGP SIGNATURE-----

--aQGiOMhPc6tAMehJ--