DKIM2-Signature: i=1; m=1; t=1791035300; d=kurilemu.de;
	mf=PGFsdmhlcnJlQGt1cmlsZW11LmRlPg==;
	rt=PHBnc3FsLWhhY2tlcnNAbGlzdHMucG9zdGdyZXNxbC5vcmc+;
	s=fm3:rsa-sha256:GIH+/e/oF2M/cnfgmAkoLmGPbhfTsNVf1e5PnW7ZQkJiQ6I
	BycgBiO/Z9pSeFdURxjRYrErfZvjxZrnk9yy2UH/uh+SEwDqamb6P+NU1bmW02lJ
	VXDBMbTmViMNyRMKLJpy/XNDPwXZvP0G07qHAxHzv1xfop7Qosb+nN5NtVWhK3zI
	k5TyYQ+G/snfQxSqKLkR/H8eHuzkyeUngJjpo3W0gu5lrW8W4WL+fxmUhkBcvn5y
	6r0y4m127idIvlQEdFBPmz0wSDT+W20WcwP7HOy1DIprkV52S6Yt6O6DFI78lmDT
	ZjcsJNe+thXiRNAnMg3eM/aM7muebIfCEBywuzg==;
Message-Instance: m=1;
 h=sha256:blgyeUZHJ5DJ/TuQnZfRvn3+yTMWa5kjzoggD3fhll4=:xWg/ZonluA6B4uHDk3eFwxsW8jrCPG8h0xa/8X7whCs=;
Feedback-ID: ie3de48e3:Fastmail
Date: Sat, 3 Oct 2026 15:48:15 +0200
From: Alvaro Herrera <alvherre@kurilemu.de>
To: Antonin Houska <ah@cybertec.at>
Cc: Radim Marek <radim@boringsql.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REPACK (CONCURRENTLY) might keep dropped-column data
Message-ID: <asEEA-lMrIQpGZMN@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <83138.1790779305@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/asEEA-lMrIQpGZMN%40alvherre.pgsql>
Precedence: bulk

On 2026-Sep-30, Antonin Houska wrote:

> Álvaro Herrera <alvherre@kurilemu.de> wrote:

> > The adjust_toast_pointers() function should perhaps be renamed,
> > and the comment rewritten, since it's no longer just about toast ...
> > I didn't do that though.
> 
> Maybe prepare_concurrent_update(), as it's called right before
> apply_concurrent_update()?

Thanks, I used this name.

> BTW, I've noticed now that the 'relation' argument of adjust_toast_pointers()
> isn't used anymore. Perhaps it was used before the tuple slots have been
> introduced into the function.

Good catch.  Removed.  Yes, it was used in 0005 with v36 you submitted
[1], but it disappeared when I posted v43 [2], which is when I rewrote
it to use tuple slots.

[1] https://www.postgresql.org/message-id/87648.1772217509@localhost
[2] https://www.postgresql.org/message-id/202603191855.fzsgsnyzfvpt@alvherre.pgsql

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"El número de instalaciones de UNIX se ha elevado a 10,
y se espera que este número aumente" (UPM, 1972)