DKIM2-Signature: i=1; m=1; t=1791062600; d=kurilemu.de;
	mf=PGFsdmhlcnJlQGt1cmlsZW11LmRlPg==;
	rt=PHBnc3FsLWhhY2tlcnNAcG9zdGdyZXNxbC5vcmc+;
	s=fm3:rsa-sha256:G6mEDbvH2KLr3xp5CIckjSYue3+772zBaL0KccA725mxfuR
	gaVmsROSgsgrhVN+E+YyAav0pMp1ABmbPtYqZOWOuE134qgXan3XYWHyc7wyoDuB
	WoMDi8f9NfNNfmm3T4kOydmpgFUtit+eqraN9W4c0Ic8LhGS7ZXDYoUxfm0g/hd1
	63/q6RFeHafZaBGF5wIWZOeX4nQCgfCrAduOOIzl/3gGbjsIFRfdFL7FKprCKMxz
	c4UhTpFmnzixjYoMhPtsEm/KhHQ4OHSZ5Qzv64jjGtGxfUZsm2mSMVRzNK4symOV
	l0kHGv49Fa1BZgFt4VgCYm5Mjz+NYJiKHvjiwbQ==;
Message-Instance: m=1;
 h=sha256:Wy7CU0crnI00xy1m/ljEl2g/1a3dGA2hx3uQZBQezNA=:xInL98UyQrqmASl3XksVW1nggJG9U8ReyMA4T+xAPu0=;
Feedback-ID: ie3de48e3:Fastmail
Date: Sat, 3 Oct 2026 23:23:16 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Narek Galstyan <narek.galstyan@enterprisedb.com>,
	pgsql-hackers@postgresql.org, "narekg@berkeley.edu" <narekg@berkeley.edu>,
	ngalstyan4@gmail.com
Subject: Re: Coverage with make coverage-html is broken on latest Debian
 using lcov v2
Message-ID: <asFSm3xLI9bkHJey@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <242900.1791053460@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/asFSm3xLI9bkHJey%40alvherre.pgsql>
Precedence: bulk

On 2026-Oct-03, Tom Lane wrote:

> Testing this locally, it initially didn't seem to be doing anything.
> But that turns out to be because Red Hat has stuck with lcov 2.0-1,
> which does not produce the "duplicate file" error.  What it does do
> is blindly read every foo.gcda file twice, resulting in counts twice
> what they should be :-(.  Now I wonder whether pre-2.0 lcov did the
> same ... but I don't have an old executable laying about to test with.
> 
> I gather that coverage.postgresql.org is running a VPATH build,
> because it shows some odd coverage counts as well as even ones.
> That's impossible in an in-tree build with this bug, if I've
> diagnosed it correctly.

Hmm, no, it's running an in-tree build,

./configure --cache-file=/home/coverage/pgsrc/configure.cache --enable-depend --enable-coverage --enable-tap-tests --enable-nls --with-python --with-perl --with-tcl --with-openssl --with-libxml --with-ldap --with-pam --with-llvm --with-lz4 --enable-injection-points CFLAGS=-O0 'CPPFLAGS=-DCOPY_PARSE_PLAN_TREES -DWRITE_READ_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST' LLVM_CONFIG=/usr/bin/llvm-config-19 CLANG=clang-19 >> $LOG 2>&1

So, I was going to say that Debian packages the same version:

coverage@galvin:~$ lcov --version
lcov: LCOV version 2.0-1

but I found out that the packaging files have a patch file that modifies
the version string, so the code that's actually running is 2.3, not 2.0.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1142382

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La espina, desde que nace, ya pincha" (Proverbio africano)