Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xUGIa-00000000rte-2pfn for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Nov 2026 04:32:33 +0000 Received: from localhost ([127.0.0.1]:38590 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xUGIZ-00000005k61-2Qh7 for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Nov 2026 04:32:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:51876) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xUGIZ-00000005k5r-1BLa for pgsql-hackers@lists.postgresql.org; Fri, 20 Nov 2026 04:32:31 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xUGIW-00000000gOW-24y2 for pgsql-hackers@postgresql.org; Fri, 20 Nov 2026 04:32:30 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4bb6886d30aso3707395e9.3 for ; Thu, 19 Nov 2026 20:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795149147; x=1795753947; darn=postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NyDvPJqfS+cjeY4Vatw5IkfhwAhqo3rba4vrkYbavRQ=; b=VMPhy2JkSQenCk6eXNl/iIFR7RrxhtTGlmOHFXeQ9gjluJy3vN05yX454xqdAkq+zc 5Csv2sd4wYXjJ0z+nCPG+1BsytVd7CcMz6rntoQfCDB6U/s815YOZ/bP9cx4qo+hmofD u1liXqQTWIyY5+O0NHn9jIT7Zp2OcTvyLokueUCDwtn93I0WBfe0UFos1RA+snKb/F/m tjjTQp7yUIyBaPFJvAScmwFtqpSIwz35FjkosjUMDUuEeQFkoCHpMWYiOPSjWYqK7Umk O6L7FCZceAYgTuYfcHBV03wMQUm0DbpjXOPe+lMSSQqYmNOBg/CYj6xvTki8i+1QH3xU svag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795149147; x=1795753947; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=NyDvPJqfS+cjeY4Vatw5IkfhwAhqo3rba4vrkYbavRQ=; b=Z46rZfG23sniQfzjiI4YLNo69OpzIqXea2TuP5jtkfQN9GfJAOnNYR+pBIPjA64M1j kHsuEHNQmy+7T1ido5pkWggKt9ZLJyQiOWxE2xJds31jwORvYyXKnu5wX7RHfZ1f05fj 0RBXGAKXuiCHms1snpFBbS1XuVY/Y3UVXKYFyGVp6yJupNZYvNZek1+kuyLs2kGPu9SJ Vw2lwfBTJQgRdMPyCmGlhGb3gtY29uDSifllUZO2gHUiChY1AsZltn1xeMuPQkK62Oc0 /NwDk8oOiNQI9NbihU2QVuYAd7SewF2Yi0yCWF5cOjNqMoRlJrD5wIJ/n6BkO/8nzNDw RuQQ== X-Forwarded-Encrypted: i=1; AL+hErHpPV8mgAFtgUM4ulo+69oz9iDIkvZj2M6bpW7ED0gL54YsNDpfFJjzluzWvTIs3QgnlGnGRgrxvNuxzPOr@postgresql.org X-Gm-Message-State: APuU4Z8cJOjVqZtwjv3SBNEuuz3Vn87oS9WhoSEfsBK6cdhpdZkWNlMF Kz8bhJAGbaLh9Sv48vey4XYqGKEgBvxYastdjRghvNZ08j3Y9zSBDHO0 X-Gm-Gg: AYBFou19Kbygjj/QFrBevKAgC3YF4KIU5HXYy2XPoMb1aLb3JfjQTs3ekjl5VnjEZfQ w9yAxrjSwbKH5Ph+5asfy0fCYlXPyILwBmRkT5zHhj+3PiuhWUKqMyW7dyMbDRSAnGxeaS/LOuQ sIDZx5bmXppwN74MMs5cDybrRqMfstFDMSK0KFJeoRm3q3/yOXAuWf9j5KOpCzg7XGcjt0r69Bh HzNAmWKzDMl6pLWcQoZPMIz4qG9ihu+fgmd5J6pTukj94f4naYRQTosto3gE7mNjF9Pt56jPga0 wjzfKlDoJdAsi/6huK8drCZwS7B5r/6bPsG7dyIqBhIOjpTbrj28geIlHPk4v3MW1PvaMYCWvt0 qzLTzUcdpU4LolgJnZOZD6mJ6BwAli3P5fUh4tf6FSQeAcqFs6wwd0dKphxrROPRAZqDJ4p3NtI XX3bcHfCFxdbzxL3A57FArU5S8/4HRUD5YQcZkYjtDI6+VyeST1vCnPBXV7btwVOn4j1JT6AmjS V++h/rS1sKwCtqSlB7eSQfs8A9XHA9eK+3xRrv8FYFuUjzyQmPG5DwSyLGG4xPUtqrGZH0AeHtS J4PZb7Y8U/9cL551c/ayIGMEu9dCZlLWS28LKgmGk4FsyghjX67lvkVUa04RU52hQccUJONO4TT kw6O29KUCAiYD X-Received: by 2002:a05:600d:12:b0:4bb:8143:e182 with SMTP id 5b1f17b1804b1-4bb88800168mr28830365e9.5.1795149146935; Thu, 19 Nov 2026 20:32:26 -0800 (PST) Received: from bdtpg (ec2-15-237-197-144.eu-west-3.compute.amazonaws.com. [15.237.197.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb884c3063sm50491435e9.15.2026.11.19.20.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 20:32:26 -0800 (PST) Date: Fri, 20 Nov 2026 04:32:25 +0000 From: Bertrand Drouvot To: Masahiko Sawada Cc: Amit Kapila , Zhijie Hou , Bharath Rupireddy , Chao Li , Fujii Masao , PostgreSQL-development Subject: Re: Add a hook for handling logical decoding messages on subscribers. Message-ID: References: <4d9e1d2f-27a2-40ec-92c8-4b5740736cf8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Thu, Nov 19, 2026 at 03:42:06PM -0800, Masahiko Sawada wrote: > On Thu, Nov 19, 2026 at 2:49 AM Amit Kapila wrote: > > > > On Wed, Nov 18, 2026 at 12:13 PM Bertrand Drouvot > > wrote: > > > > > > On Tue, Nov 17, 2026 at 02:14:15PM -0800, Masahiko Sawada wrote: > > > > On Tue, Nov 17, 2026 at 12:14 AM Bertrand Drouvot > > > > wrote: > > > > > > > Given that the 0001 patch is not backpatched, I think the subscriber > > > > should request the messages option only from v20 or later publishers, > > > > like it doesn't send the origin option to publishers older than v16. > > > > The patch already checks the publisher version there, so we just need > > > > to raise it from v14 to v20. What do you think? > > > > > > One difference with origin is that older publishers do not support that option > > > at all, whereas v14 through v19 publishers support messages and the issue occurs > > > only when streaming is enabled. > > > > > > I wonder if it would make sense to request messages from those publishers when > > > streaming is disabled, and require v20 or later when streaming is enabled? > > > > > > > We could use one of the ideas proposed or just leave as it is. It is > > possible that there is no such use till now, so, adding more version > > checking in the code for such things may not add much value. > > I'd like to keep it simple and require v20 or later regardless of the > streaming option. Since streaming defaults to parallel, the > subscribers would have to give up the performance benefit of > streaming. So I don't think it's worth adding another check for them, > as Amit said. Yeah, that sounds reasonable to me. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com