Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xRRh4-00000000yWL-0gjy for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Nov 2026 10:06:10 +0000 Received: from localhost ([127.0.0.1]:59478 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xRRh1-0000000Frny-2szT for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Nov 2026 10:06:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:59402) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xRRh1-0000000Frnp-1fGk for pgsql-hackers@lists.postgresql.org; Thu, 12 Nov 2026 10:06:07 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xRRgz-00000000Wbk-3W5k for pgsql-hackers@postgresql.org; Thu, 12 Nov 2026 10:06:06 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-c4d473cfff6so570639666b.0 for ; Thu, 12 Nov 2026 02:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794477964; x=1795082764; darn=postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=yU+Kol5pc+S4AIwsolmfmfjCHumlnUd7Cs58pV7FdbQ=; b=FVsSybHZKHYOtIO2B2N8f6kv92rNFSO/d0YlOXc42fT0dgAS5d++zRTcEG8RiuTBH6 14Ugee8SiXy/c9G87WYrXgaGKqJc1HVtOft3PPwkfmPCOBPWpHdyvtyq72feWWAKsokJ Dd9L6Rg1Qb+pNm3Xd4yn2Bqly9ZR6TNuzPETpw70VcFxy+DBGNX1OeSSojUQ+Qww67xk dPCwTarWtjo7Eju58yuRG2EHEwPgmvAgmgdXSK0/dGbUJPWeez++qrL5VP1FgXm0PuaY e2B51FOvRB6dQ3j2rhSQVIIw9NIj1d3m/L3zReP+BjD/8yayfziymZ6GqKbXleLGbECB M2/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794477964; x=1795082764; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=yU+Kol5pc+S4AIwsolmfmfjCHumlnUd7Cs58pV7FdbQ=; b=DMfOvIuotrhR7UZusfoOvmhJipp6u5oLrg35cj50hVbYaefmr3GBRd94Z37UgKZFLm Hd2m7JVF9tvpEdR+vYghGct/uD+pnjlKaPuBWZlN3Q6ZxQ91oxoevuvXZlnqx8l0CbP8 dmqgwdhCYyzCmSUhmCfAzOWP85KpOoOX/mDiCT3JMDd7UvONBVTq121IUEs0XTWaq727 DO7WgUVXEIcXOdBJSaHrI9+pphdslIj8r7o5YaRUVjbgWrKsCeAubGdQi+cJqautFJFZ Skl6DesiGm5AW9Mn+wfxci8j+OkKThPDwH2JbIN8U/vZ5IHXMXK2an9MugWSpBmNUHSy oUNA== X-Forwarded-Encrypted: i=1; AL+hErGff2zjLs8pvKMSyA3zCBMapBLjW8UPI8YSzX5o4Z9Kq3ePWBVdUeGgLZDPBEF+xy/GYQTRIty3SIbi1/yD@postgresql.org X-Gm-Message-State: APuU4Z8ZWfVIcT5YvMk/kDqrel9+G+ljRef9SX80YgUQJhby+bLGxOr5 OzWRYaTtzx4NMY8xtXJ76uPsGOFv07GoUrGsGO67rlDmIPQVv6DIOEI6 X-Gm-Gg: AYBFou29AsC/0OcDUyBNNUN7qECVUq4II6B/nEP8UdG0OgV5MvbicEnbH4seyt0iv6n r06pj3cg/fe9QevWfEoZXiBUG7WkpJYQcyB5zfNNDMsgabtuRIbBSCcVNQbz3fZrCaUCdJ/en7v xFqDVZVS9Hmx2MgvScrLLxdwbH1/BOpHRTn3JoxB5QANahvD/QbOhm/BX3UhFUoDw174ohPhC2r GUzGJ/InCJd6Jr7tkih1Q/YI4jpJW0fkrIKdRr5RYHOx+XKOHwOVSJYWHJelBg30XAeOZmj+728 CjdOm2NNq2vqHdj+4fo5+Ec1/8ka6B6OZerwC1eHFqDea4hT47SHFBVtOEujgZqVwYfcS+JtAlV g+oM8I+qGYOvgJ302X14gLGG2RTBYeqv2snQYQOKsErL+if6fiAYm76Xo7BEXzRc3Th57lb7K1v /ar/VSzPSz4artILbyfUDluL+n2K6C8l3t9mcC3xGx9kUTUrzCjyVjiWivrGcYfu6dGwNUBfDrB yiW25WsIElHfqOX8DUxOEne9WPANWtTrM1wnwm4Ahdk6jQXNV//XhdXyafDq0N+jPJy5ANiphMv up761oswDuur1exHAMC4dzKarNyAQXobH/9FInsRxZCPrcxWHqcm6uHm918chG2h9djoOhgSpRb ciA/cKM7jtPfq6Q== X-Received: by 2002:a17:907:c26:b0:c46:723d:600 with SMTP id a640c23a62f3a-c5066d52974mr397219966b.41.1794477963764; Thu, 12 Nov 2026 02:06:03 -0800 (PST) Received: from bdtpg (ec2-15-237-197-144.eu-west-3.compute.amazonaws.com. [15.237.197.144]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-498369a3fd2sm16562515f8f.52.2026.11.12.02.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 02:06:03 -0800 (PST) Date: Thu, 12 Nov 2026 10:06:02 +0000 From: Bertrand Drouvot To: Amit Kapila Cc: Masahiko Sawada , Zhijie Hou , Bharath Rupireddy , Chao Li , Fujii Masao , PostgreSQL-development Subject: Re: Add a hook for handling logical decoding messages on subscribers. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, Sorry for joining this discussion so late. On Thu, Nov 12, 2026 at 03:02:44PM +0530, Amit Kapila wrote: > On Thu, Nov 12, 2026 at 4:10 AM Masahiko Sawada wrote: > > > > On Mon, Nov 9, 2026 at 5:21 PM Masahiko Sawada wrote: > > > > > > I've attached the new patches. I just updated the commit message for > > > the 0001 patch, and added some fixes and regression tests for the 0002 > > > patch. Please review them. > > > > I think the 0001 patch can be pushed independently. So I'm going to > > push it to master, barring objections. > > > > Few comments on 0001: > * As we are planning this as a master-only change, will it be better > if we just pass subxid as a separate parameter to keep the interface > consistent with other similar interfaces and avoid the need for > plugins to retrieve toptxn separately. +1. That would also prevent the crash mentioned in the commit message, as txn would remain the top level transaction. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com