Feedback-ID: i131946ab:Fastmail
Message-ID: <b0084395-5379-3872-035a-a974aa5845fb@enterprisedb.com>
Date: Thu, 16 Mar 2023 16:24:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: improving user.c error messages
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Tom Lane <tgl@sss.pgh.pa.us>,
 Robert Haas <robertmhaas@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <20230127000936.GA1998073@nathanxps13>
 <20230127183119.e5jtyh4g2md57ctb@alvherre.pgsql>
 <20230127231507.GA2221340@nathanxps13> <20230207201009.GA450353@nathanxps13>
 <e1bbef97-ed13-f6ad-8d21-b2ebc251394b@enterprisedb.com>
 <20230220190210.GA3481922@nathanxps13> <20230220225852.GA3940888@nathanxps13>
 <abf97f0d-79b4-217c-2ea8-d081648d9a6d@enterprisedb.com>
 <20230309175846.GA3626988@nathanxps13> <20230310000313.GA3992372@nathanxps13>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20230310000313.GA3992372@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b0084395-5379-3872-035a-a974aa5845fb%40enterprisedb.com>
Precedence: bulk

On 10.03.23 01:03, Nathan Bossart wrote:
>>> By the way, I'm not sure what the separation between 0001 and 0002 is
>>> supposed to be.
>> I'll combine them.  I first started with user.c only, but we kept finding
>> new messages to improve.
> I combined the patches in v7.

I have committed two pieces that were not message changes separately.


I think the following change in DropRole() is incorrect:

         if (!is_admin_of_role(GetUserId(), roleid))
             ereport(ERROR,
                     (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
-                    errmsg("must have admin option on role \"%s\"",
-                           role)));
+                    errmsg("permission denied to drop role"),
+                    errdetail("Only roles with the %s attribute and the 
%s option on role \"%s\" may drop this role.",
+                              "CREATEROLE", "ADMIN", 
NameStr(roleform->rolname))));

The message does not reflect what check is actually performed.  (Perhaps 
this was confused with a similar but not exactly the same check in 
RenameRole().)

That was the only "factual" error that I found.


In file_fdw_validator(), the option names "filename" and "program" could 
be parameterized.


In DropOwnedObjects() and ReassignOwnedObjects(), I suggest the 
following changes, for clarity:

- errdetail("Only roles with privileges of role \"%s\" may drop its 
objects.",
+ errdetail("Only roles with privileges of role \"%s\" may drop objects 
owned by it.",

- errdetail("Only roles with privileges of role \"%s\" may reassign its 
objects.",
+ errdetail("Only roles with privileges of role \"%s\" may reassign 
objects owned by it.",


The rest looks okay to me.