public inbox for [email protected]  
help / color / mirror / Atom feed
From: [email protected]
To: [email protected]
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
Date: Mon, 12 Sep 2022 15:47:09 +0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAJ_b95nneRCLM-=qELEdgCYSk6W_++-C+Q_t+wH3SW-hF50iw@mail.gmail.com>
References: <CAAJ_b95nneRCLM-=qELEdgCYSk6W_++-C+Q_t+wH3SW-hF50iw@mail.gmail.com>

Hi,

The commit 4fb5c794e5 eliminates the ginbulkdelete() test coverage 
provided by the commit 4c51a2d1e4 two years ago.
With the following Assert added:
@@ -571,7 +571,7 @@ ginbulkdelete(IndexVacuumInfo *info, 
IndexBulkDeleteResult *stats,
         Buffer          buffer;
         BlockNumber rootOfPostingTree[BLCKSZ / (sizeof(IndexTupleData) + 
sizeof(ItemId))];
         uint32          nRoot;
-
+       Assert(0);
         gvs.tmpCxt = AllocSetContextCreate(CurrentMemoryContext,
                                                                          
   "Gin vacuum temporary context",
                                                                          
   ALLOCSET_DEFAULT_SIZES);
I have check-world passed successfully.

Amul Sul писал 2021-11-29 12:04:
> Hi,
> 
> Attached patch is doing small changes to brin, gin & gist index tests
> to use an unlogged table without changing the original intention of
> those tests and that is able to hit ambuildempty() routing which is
> otherwise not reachable by the current tests.





view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox