Feedback-ID: ie0a040ee:Fastmail
Message-ID: <b0e5aebb-3d4a-4dd2-93e7-6c5e2f3ba033@eisentraut.org>
Date: Wed, 27 Dec 2023 22:52:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [HACKERS] Changing references of password encryption to hashing
Content-Language: en-US
To: Bruce Momjian <bruce@momjian.us>, Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>,
 Michael Paquier <michael.paquier@gmail.com>,
 PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
References: <CAB7nPqR82_57C8O1+z-bUChhHpdjMec_omLfKwYdjAFjjcrBWg@mail.gmail.com>
 <ZV149Fd2JG_OF7CM@momjian.us> <ZWX/Y5napgIxs6VA@tamriel.snowman.net>
 <CA+Tgmoa44Q+rajT2FC2S7R3-hfh0xXTEa+qLzdYD0Gh9DPoX3Q@mail.gmail.com>
 <ZYt4JfkJMCck4IkK@momjian.us>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <ZYt4JfkJMCck4IkK@momjian.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/b0e5aebb-3d4a-4dd2-93e7-6c5e2f3ba033%40eisentraut.org>
Precedence: bulk

On 27.12.23 02:04, Bruce Momjian wrote:
> I did_not_  change the user API, so CREATE/ALTER ROLE still uses
> [ENCRYPTED] PASSWORD, the GUC is still called password_encryption, and
> the libpq function is still called PQencryptPasswordConn().  This makes
> the user interface confusing since the API uses "encryption" but the
> text calls it "hashing".  Is there support for renaming the API to use
> "hash" and keeping "encrypt" for backward compatiblity.

Yeah, this is clearly confusing.  I think we should just leave it alone. 
  Some gentle rewording here and there to clarify things might be 
appropriate (but the text already uses hashing on some occasions), but 
the blanket replacement does not make things better, I think.