Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmhhU-0003nQ-HM for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Jan 2019 16:17:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gmhhS-0006X8-8Z for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Jan 2019 16:17:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmhhR-0006NH-Pd for pgsql-hackers@lists.postgresql.org; Thu, 24 Jan 2019 16:17:54 +0000 Received: from mail-yb1-xb42.google.com ([2607:f8b0:4864:20::b42]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmhhN-00083t-PA for pgsql-hackers@lists.postgresql.org; Thu, 24 Jan 2019 16:17:52 +0000 Received: by mail-yb1-xb42.google.com with SMTP id y63so2580132ybc.8 for ; Thu, 24 Jan 2019 08:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=BQEG9P6NUhsQs5zUP66OzcNb5MuT9zW+r5o1DppCzHk=; b=rn/fsyQikokxjxeKVQIgwX/t7q8W7Nnnsr0g2KelP54qajEm4MiF6ZweEjy9UbOaTV 1oLuOTHNhZDwhRDQTonQL3YoFGVuogudx8mSP8jT6wvjRl4LC+vZhU/jIShdkAtAfYbs 0OlR98UhNPCxyvtZS5cIbxvA5E1RxZtSApDxovMRNEgIEYvnwTMiSN1qaaYbwHH0KEXC cQylxYo0YXmFgPuoHcuLv67YGnE8rPWeSujKzYypOv6/KaGsNkPGAM8qaiQv8UYYOQnN rG4p16QqDfrOuvLd/NrFYdM6S7QZf80HfUJyROxi4CWOU15QwWguXjlUh6Bt0QFE0v1r K/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=BQEG9P6NUhsQs5zUP66OzcNb5MuT9zW+r5o1DppCzHk=; b=hZhFe5Q7zGgXgG5cbXQcmVv+9x9sexxmGIgFJFw4uI5YyXQRfpe0qaBsBgtKZWKK1g VI7LBmXwCjLy/J7OC92HIyWaZCVBDGkN2V7Eudl6lExlI936t8EVSfiDUTBCJEnAYChX EVnUXTyisPg9d5UWPZBciAd47nkJEdo138k7aoBUda9l7bwhmdvTWSllsX5u7b5CBRVF sIGeE+JOSLMYu25X8bn2+isjZn8Yk3qWD8Ml/H2zKfnja1BtkGFY9aeMC7E3QOvcxBPZ pDARYSkln3zyG0scm/Mwlw1AqbBZYOU0BTgZGAK3eSRfP9fObdarv1m4anKlfPw9ceI+ /m7w== X-Gm-Message-State: AJcUukeoIz3kmmshe8g6VtfP4qYyvsgkYIoXL6osVnExkIp7eueMlY+I /8L/DG7fjSh6Q6s2hG5JVicrDQzbIcwXMjxtcon58BJxN5rbymlBarrz5dHZiN61xkd1iUm2zNX 7rtv0poi4uUctlVb1q4xYflKqudz5BRbpch25qY2KPZny0xdrEWrZ4msn6byuRctOgPCAfg6PLA VjVkdvvsULjnbWP/0SwEV4 X-Google-Smtp-Source: ALg8bN5MDSr7WMDrTmLL5G8BwtE13UHp3kTGw8NPey2uHEodcUoRJYwQCnAsLnSdaE+/l7eN9iI6PQ== X-Received: by 2002:a25:bc06:: with SMTP id i6mr6575294ybh.340.1548346668472; Thu, 24 Jan 2019 08:17:48 -0800 (PST) Received: from [192.168.10.146] ([98.122.175.38]) by smtp.gmail.com with ESMTPSA id k62sm9336591ywk.84.2019.01.24.08.17.46 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:17:47 -0800 (PST) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan Subject: Re: Thread-unsafe coding in ecpg To: Tom Lane Cc: "Joshua D. Drake" , Andres Freund , "Tsunakawa, Takayuki" , Michael Meskes , "pgsql-hackers@lists.postgresql.org" References: <24002.1547944649@sss.pgh.pa.us> <29905.1548005448@sss.pgh.pa.us> <29984.1548014676@sss.pgh.pa.us> <0A3221C70F24FB45833433255569204D1FB6C47E@G01JPEXMBYT05> <21439.1548037255@sss.pgh.pa.us> <0A3221C70F24FB45833433255569204D1FB6C4FA@G01JPEXMBYT05> <32316.1548040561@sss.pgh.pa.us> <0A3221C70F24FB45833433255569204D1FB6C6C0@G01JPEXMBYT05> <13850.1548090570@sss.pgh.pa.us> <20190121193512.tdmcnic2yjxlufaw@alap3.anarazel.de> <20352.1548101123@sss.pgh.pa.us> <0f02fb0d-0a80-0dad-a01e-e6879d24e48f@commandprompt.com> <27185.1548102332@sss.pgh.pa.us> <38244c62-e1cc-40f5-d567-777540815c16@2ndQuadrant.com> <25026.1548284495@sss.pgh.pa.us> <62a84a11-5d3e-1238-afd5-ec11ba91bb09@2ndQuadrant.com> <9460.1548299404@sss.pgh.pa.us> <18693.1548302004@sss.pgh.pa.us> Openpgp: preference=signencrypt Autocrypt: addr=andrew.dunstan@2ndQuadrant.com; prefer-encrypt=mutual; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNL0FuZHJldyBEdW5zdGFuIDxhbmRyZXcuZHVuc3RhbkAybmRRdWFkcmFudC5jb20+wsCY BBMBAgBCAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUJDyV6hBYhBOQ+WEYd/Hy/RGkV pZn6f8tZ/DuBBQJcH/EVAhkBAAoJEJn6f8tZ/DuB7BEH/iDWZEbVft2m2MT6SPjARzTupt/l xLLZ/Cl6n2US2hov5+fBbnR5xvECk/YCOfG9ICvKNlpFjceqNLRKStd8cmndnI+kDw91uNM2 hpL4aJMeW65XCHvqXlOLSwv5chBpXz9NG7FMaJ+q+59sWEWjcTNmjXgkEHn53y+1pc7nSLDe cr5ZI1aB3nGXRm1SoDY5PYZkUKMykW+YBZwgcs/Q5tRaE+siN7DKbz8E628+PerwAkmHPVXN MdJFD6gs4S0gDFA8IxcyIwZU2v4By+brzcJ9Se3FK5BYxBDHtaYZxgSrJAvOUOrLIZPQTQfL TtnVs3C3JTfrxCH1ceHtnA6dRuTOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oK Waqf+wmW4tpDe/VVcxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7 llV0xSSoFiieQBsrGvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8 BoVrRFcdzlIY/NFNhFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C 4R+M6w7o2PLGOjdZ+kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaY L++LAEOqrlvm2TvqQqZRtnEAEQEAAcLAZQQYAQIADwIbDAUCXA6fpAUJDyV6xAAKCRCZ+n/L Wfw7geU4B/9vFFsVmWxerDWgNjyiK80zIPmlw/iwdUlU6FIu0JWLMg4093kvxBs7RMZV9hBq n3ekBvD4IvFsVLJrw9qzSI2FH3UeYy5WXpEs01Ppia60NOlvRDqXbryzuvfe+iYo6bVP3Ikr TPTNYL/BePUTD2DPvSI82SbGTyzuA7SJv6NRqqQDMIy1fU6KyQFLmQJp/QJyhKWzm9jWh8ee w8jVaoMY0Kbq5N7RqisEx1Lu/Iw646UphdYzQNymf+kbiU5Kf4I6DhzV8w9sie1Bo1juNj3I c5/fFJsmxljbnaDbXPcnFsur1Oo9mIHFakgWgOBMuxoWfjONiLjjLh/9+ZIqSSLX Message-ID: Date: Thu, 24 Jan 2019 11:17:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <18693.1548302004@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-MW List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 1/23/19 10:53 PM, Tom Lane wrote: > I wrote: >> This suggests that, rather than throwing up our hands if the initial >> _configthreadlocale call returns -1, we should act as though the function >> doesn't exist, and just soldier on the same as before. The code in there >> assumes that -1 is a can't-happen case and doesn't try to recover, >> but apparently that's over-optimistic. > I pushed a patch to fix that. jacana has been upgraded to gcc 8.1.0 so it knows about _configthreadlocale() and it's now happy. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services