public inbox for [email protected]
help / color / mirror / Atom feedFrom: Jacob Champion <[email protected]>
To: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [PATCH] Support pg_ident mapping for LDAP
Date: Wed, 1 Sep 2021 20:56:21 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALNJ-vRQpSkineEB_YB9m64GBMLinF=j6zuUHOhpfgMFjWKMWw@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<[email protected]>
<CALNJ-vRQpSkineEB_YB9m64GBMLinF=j6zuUHOhpfgMFjWKMWw@mail.gmail.com>
On Wed, 2021-09-01 at 12:59 -0700, Zhihong Yu wrote:
> + if (strcmp(val, "1") == 0)
> + hbaline->ldap_map_dn = true;
> + else
> + hbaline->ldap_map_dn = false;
>
> The above can be shortened as:
>
> hbaline->ldap_map_dn = strcmp(val, "1") == 0;
I usually prefer simplifying those conditionals, too, but in this case
I think it'd be a pretty big departure from the existing style. See for
example the handling of include_realm and compat_realm just after this
hunk.
--Jacob
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [PATCH] Support pg_ident mapping for LDAP
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox