Subject: Re: Support tab completion for upper character inputs in psql
To: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
 David Zhang <david.zhang@highgo.ca>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: 
 <a63cbd45e3884cf9b3961c2a6a95dcb7@G08CNEXMBPEKD05.g08.fujitsu.local>
 <457958.1612724100@sss.pgh.pa.us>
 <20210208.170212.1547983279045749071.horikyota.ntt@gmail.com>
 <696766648c7a4266864f843b0e4140dd@G08CNEXMBPEKD05.g08.fujitsu.local>
 <5f225addccc54478a6436b78423f21be@G08CNEXMBPEKD05.g08.fujitsu.local>
 <24171b05-cf0f-3073-a73a-57b45b794049@enterprisedb.com>
 <TYCPR01MB612814C94F90274B8B0D1480FB659@TYCPR01MB6128.jpnprd01.prod.outlook.com>
 <3140db2a-9808-c470-7e60-de39c431b3ab@highgo.ca>
 <OS0PR01MB611349C0F17E374208DB52B1FB7B9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <b14262e4-2d53-ae20-cee8-b8db708b49d5@enterprisedb.com>
Date: Thu, 8 Apr 2021 09:13:44 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: 
 <OS0PR01MB611349C0F17E374208DB52B1FB7B9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b14262e4-2d53-ae20-cee8-b8db708b49d5%40enterprisedb.com>
Precedence: bulk

On 01.04.21 11:40, tanghy.fnst@fujitsu.com wrote:
> On Wednesday, March 31, 2021 4:05 AM, David Zhang <david.zhang@highgo.ca> wrote
> 
>>    8 postgres=# update tbl SET DATA =
>>    9
>>   10 postgres=# update TBL SET
>>   11
>>   12 postgres=#
>>
>> So, as you can see the difference is between line 8 and 10 in case 2. It
>> looks like the lowercase can auto complete more than the uppercase;
>> secondly, if you can add some test cases, it would be great.
> 
> Thanks for your test. I fix the bug and add some tests for it.
> Please find attached the latest patch V4.
> 
> Differences from v3 are:
> * fix an issue reported by Zhang [1] where a scenario was found which still wasn't able to realize tap completion in query.
> * add some tap tests.

Seeing the tests you provided, it's pretty obvious that the current 
behavior is insufficient.  I think we could probably think of a few more 
tests, for example exercising the "If case insensitive matching was 
requested initially, adjust the case according to setting." case, or 
something with quoted identifiers.  I'll push this to the next commit 
fest for now.  I encourage you to keep working on it.