Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuPcV-008Fh7-0B for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 05:36:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tuPbT-007zPx-Ks for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 05:35:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuPbT-007zPp-Ac for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 05:35:03 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tuPbO-003RrA-2P for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 05:35:01 +0000 Received: from [192.168.11.3] (p1695135-ipoe.ipoe.ocn.ne.jp [118.0.92.134]) by oss.nttdata.com (Postfix) with ESMTPSA id F1BD8619C1; Tue, 18 Mar 2025 14:34:52 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Content-Type: multipart/mixed; boundary="------------UOsIgpRN27Re2rCXURSdiDJd" Message-ID: Date: Tue, 18 Mar 2025 14:34:52 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pg_recvlogical requires -d but not described on the documentation To: "David G. Johnston" , "Hayato Kuroda (Fujitsu)" Cc: Ashutosh Bapat , "pgsql-hackers@lists.postgresql.org" References: Content-Language: en-US From: Fujii Masao In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------UOsIgpRN27Re2rCXURSdiDJd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025/03/12 14:59, David G. Johnston wrote: > On Monday, February 24, 2025, Hayato Kuroda (Fujitsu) > wrote: > > > OK, so I will exclude the point in the thread. The patch I've posted contains all of fixes > which is required. > > > The patch fixes the synopsis and the mention of the default value.  Only the later is required.  I cannot figure out a policy that would alter the synopsis in the proposed manner.  I’d suggest leaving it alone for now and tweak any of the option descriptions that may need clarification. I agree that the synopsis doesn't need to be updated. Attached patch clarifies the required options for each action in the documentation. Thought? BTW, I'm curious why --dbname isn't required for the --drop-slot action. When I ran pg_recvlogical --drop-slot without --dbname, I got the following error: pg_recvlogical: error: could not establish database-specific replication connection Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------UOsIgpRN27Re2rCXURSdiDJd Content-Type: text/plain; charset=UTF-8; name="v2-0001-doc-Clarify-required-options-for-each-action-in-p.patch" Content-Disposition: attachment; filename*0="v2-0001-doc-Clarify-required-options-for-each-action-in-p.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4ZGNjNTNhNmJlYmVhYTFjNGQwZGRhYWNkMzVhM2M0NTAzMjdiZmVmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v cmc+CkRhdGU6IFR1ZSwgMTggTWFyIDIwMjUgMTA6MDc6MDggKzA5MDAKU3ViamVjdDogW1BB VENIIHYyXSBkb2M6IENsYXJpZnkgcmVxdWlyZWQgb3B0aW9ucyBmb3IgZWFjaCBhY3Rpb24g aW4KIHBnX3JlY3Zsb2dpY2FsCgpFYWNoIHBnX3JlY3Zsb2dpY2FsIGFjdGlvbiByZXF1aXJl cyBzcGVjaWZpYyBvcHRpb25zLiBGb3IgZXhhbXBsZSwKLS1zbG90LCAtLWRibmFtZSwgYW5k IC0tZmlsZSBtdXN0IGJlIHNwZWNpZmllZCB3aXRoIHRoZSAtLXN0YXJ0IGFjdGlvbi4KUHJl dmlvdXNseSwgdGhlIGRvY3VtZW50YXRpb24gZGlkIG5vdCBjbGVhcmx5IG91dGxpbmUgdGhl c2UgcmVxdWlyZW1lbnRzLgoKVGhpcyBjb21taXQgdXBkYXRlcyB0aGUgZG9jdW1lbnRhdGlv biB0byBleHBsaWNpdGx5IHN0YXRlCnRoZSBuZWNlc3Nhcnkgb3B0aW9ucyBmb3IgZWFjaCBh Y3Rpb24uCi0tLQogZG9jL3NyYy9zZ21sL3JlZi9wZ19yZWN2bG9naWNhbC5zZ21sIHwgMjYg KysrKysrKysrKysrKysrKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL3JlZi9w Z19yZWN2bG9naWNhbC5zZ21sIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZWN2bG9naWNhbC5z Z21sCmluZGV4IDk1ZWIxNGI2MzUyLi4yOTQ2YmRhZTFlNSAxMDA2NDQKLS0tIGEvZG9jL3Ny Yy9zZ21sL3JlZi9wZ19yZWN2bG9naWNhbC5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9yZWYv cGdfcmVjdmxvZ2ljYWwuc2dtbApAQCAtNzMsNiArNzMsMTEgQEAgUG9zdGdyZVNRTCBkb2N1 bWVudGF0aW9uCiAgICAgICAgIGJ5IDxvcHRpb24+LS1kYm5hbWU8L29wdGlvbj4uCiAgICAg ICAgPC9wYXJhPgogCisgICAgICAgPHBhcmE+CisgICAgICAgIFRoZSA8b3B0aW9uPi0tc2xv dDwvb3B0aW9uPiBhbmQgPG9wdGlvbj4tLWRibmFtZTwvb3B0aW9uPiBhcmUgcmVxdWlyZWQK KyAgICAgICAgZm9yIHRoaXMgYWN0aW9uLgorICAgICAgIDwvcGFyYT4KKwogICAgICAgIDxw YXJhPgogICAgICAgICBUaGUgPG9wdGlvbj4tLXR3by1waGFzZTwvb3B0aW9uPiBjYW4gYmUg c3BlY2lmaWVkIHdpdGgKICAgICAgICAgPG9wdGlvbj4tLWNyZWF0ZS1zbG90PC9vcHRpb24+ IHRvIGVuYWJsZSBkZWNvZGluZyBvZiBwcmVwYXJlZCB0cmFuc2FjdGlvbnMuCkBAIC04Nyw2 ICs5MiwxMCBAQCBQb3N0Z3JlU1FMIGRvY3VtZW50YXRpb24KICAgICAgICAgRHJvcCB0aGUg cmVwbGljYXRpb24gc2xvdCB3aXRoIHRoZSBuYW1lIHNwZWNpZmllZAogICAgICAgICBieSA8 b3B0aW9uPi0tc2xvdDwvb3B0aW9uPiwgdGhlbiBleGl0LgogICAgICAgIDwvcGFyYT4KKwor ICAgICAgIDxwYXJhPgorICAgICAgICBUaGUgPG9wdGlvbj4tLXNsb3Q8L29wdGlvbj4gaXMg cmVxdWlyZWQgZm9yIHRoaXMgYWN0aW9uLgorICAgICAgIDwvcGFyYT4KICAgICAgIDwvbGlz dGl0ZW0+CiAgICAgIDwvdmFybGlzdGVudHJ5PgogCkBAIC0xMDEsNiArMTEwLDExIEBAIFBv c3RncmVTUUwgZG9jdW1lbnRhdGlvbgogICAgICAgICA8b3B0aW9uPi0tbm8tbG9vcDwvb3B0 aW9uPiBpcyBzcGVjaWZpZWQuCiAgICAgICAgPC9wYXJhPgogCisgICAgICAgPHBhcmE+Cisg ICAgICAgIFRoZSA8b3B0aW9uPi0tc2xvdDwvb3B0aW9uPiBhbmQgPG9wdGlvbj4tLWRibmFt ZTwvb3B0aW9uPiwKKyAgICAgICAgPG9wdGlvbj4tLWZpbGU8L29wdGlvbj4gYXJlIHJlcXVp cmVkIGZvciB0aGlzIGFjdGlvbi4KKyAgICAgICA8L3BhcmE+CisKICAgICAgICA8cGFyYT4K ICAgICAgICAgVGhlIHN0cmVhbSBmb3JtYXQgaXMgZGV0ZXJtaW5lZCBieSB0aGUgb3V0cHV0 IHBsdWdpbiBzcGVjaWZpZWQgd2hlbgogICAgICAgICB0aGUgc2xvdCB3YXMgY3JlYXRlZC4K QEAgLTE1OSw2ICsxNzMsOSBAQCBQb3N0Z3JlU1FMIGRvY3VtZW50YXRpb24KICAgICAgICAg V3JpdGUgcmVjZWl2ZWQgYW5kIGRlY29kZWQgdHJhbnNhY3Rpb24gZGF0YSBpbnRvIHRoaXMK ICAgICAgICAgZmlsZS4gVXNlIDxsaXRlcmFsPi08L2xpdGVyYWw+IGZvciA8c3lzdGVtaXRl bT5zdGRvdXQ8L3N5c3RlbWl0ZW0+LgogICAgICAgIDwvcGFyYT4KKyAgICAgICA8cGFyYT4K KyAgICAgICAgVGhpcyBwYXJhbWV0ZXIgaXMgcmVxdWlyZWQgZm9yIDxvcHRpb24+LS1zdGFy dDwvb3B0aW9uPi4KKyAgICAgICA8L3BhcmE+CiAgICAgICA8L2xpc3RpdGVtPgogICAgICA8 L3Zhcmxpc3RlbnRyeT4KIApAQCAtMjY1LDYgKzI4Miw5IEBAIFBvc3RncmVTUUwgZG9jdW1l bnRhdGlvbgogICAgICAgICBtb2RlLCBjcmVhdGUgdGhlIHNsb3Qgd2l0aCB0aGlzIG5hbWUu IEluIDxvcHRpb24+LS1kcm9wLXNsb3Q8L29wdGlvbj4KICAgICAgICAgbW9kZSwgZGVsZXRl IHRoZSBzbG90IHdpdGggdGhpcyBuYW1lLgogICAgICAgIDwvcGFyYT4KKyAgICAgICA8cGFy YT4KKyAgICAgICAgVGhpcyBwYXJhbWV0ZXIgaXMgcmVxdWlyZWQgZm9yIGFueSBvZiBhY3Rp b25zLgorICAgICAgIDwvcGFyYT4KICAgICAgIDwvbGlzdGl0ZW0+CiAgICAgIDwvdmFybGlz dGVudHJ5PgogCkBAIC0zMDUsNyArMzI1LDExIEBAIFBvc3RncmVTUUwgZG9jdW1lbnRhdGlv bgogICAgICAgICAgVGhlIDxyZXBsYWNlYWJsZT5kYm5hbWU8L3JlcGxhY2VhYmxlPiBjYW4g YmUgYSA8bGluawogICAgICAgICAgbGlua2VuZD0ibGlicHEtY29ubnN0cmluZyI+Y29ubmVj dGlvbiBzdHJpbmc8L2xpbms+LiAgSWYgc28sCiAgICAgICAgICBjb25uZWN0aW9uIHN0cmlu ZyBwYXJhbWV0ZXJzIHdpbGwgb3ZlcnJpZGUgYW55IGNvbmZsaWN0aW5nCi0gICAgICAgICBj b21tYW5kIGxpbmUgb3B0aW9ucy4gIERlZmF1bHRzIHRvIHRoZSB1c2VyIG5hbWUuCisgICAg ICAgICBjb21tYW5kIGxpbmUgb3B0aW9ucy4KKyAgICAgICAgPC9wYXJhPgorICAgICAgICA8 cGFyYT4KKyAgICAgICAgIFRoaXMgcGFyYW1ldGVyIGlzIHJlcXVpcmVkIGZvciA8b3B0aW9u Pi0tY3JlYXRlLXNsb3Q8L29wdGlvbj4KKyAgICAgICAgIGFuZCA8b3B0aW9uPi0tc3RhcnQ8 L29wdGlvbj4uCiAgICAgICAgIDwvcGFyYT4KICAgICAgICA8L2xpc3RpdGVtPgogICAgICAg PC92YXJsaXN0ZW50cnk+Ci0tIAoyLjQ4LjEKCg== --------------UOsIgpRN27Re2rCXURSdiDJd--