Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOM0c-0007lN-5B for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Mar 2021 14:58:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lOM0b-0002Rq-2m for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Mar 2021 14:58:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOM0a-0002Ri-OH for pgsql-hackers@lists.postgresql.org; Mon, 22 Mar 2021 14:58:20 +0000 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOM0X-00028W-Jt for pgsql-hackers@postgresql.org; Mon, 22 Mar 2021 14:58:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1616425097; x=1647961097; h=to:cc:references:from:message-id:date:mime-version: in-reply-to:subject; bh=tP2B0s+YOwEifL3vXOnNj/v/fh0U4IOG5r9805pU7is=; b=jRU8QjZsmWLAGGgxBZwzoLSiIE0yrMAxRJOBdmt+ijh37kEc6N5KuypP FH6zNEeZ2CadqpphhoS1UAUAje4DS6Mmda59AwspT1ZP7pbfHtwhDi9cI IVY2g3EBhigsWaBt3WlIwMCUFXVmQvitMS8jWhVCSWINQaypUp7ClVNX0 E=; X-IronPort-AV: E=Sophos;i="5.81,269,1610409600"; d="scan'208,217";a="101011545" Subject: Re: Minimal logical decoding on standbys Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-859fe132.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 22 Mar 2021 14:58:07 +0000 Received: from EX13D03EUC003.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2b-859fe132.us-west-2.amazon.com (Postfix) with ESMTPS id 9BDB1220389; Mon, 22 Mar 2021 14:58:06 +0000 (UTC) Received: from 38f9d36c4abb.ant.amazon.com (10.43.161.41) by EX13D03EUC003.ant.amazon.com (10.43.164.192) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 22 Mar 2021 14:58:02 +0000 To: CC: Alvaro Herrera , Andres Freund , tushar , "[pgdg] Robert Haas" , Amit Khandekar , Rahila Syed , pgsql-hackers References: <20200318184249.GA29007@alvherre.pgsql> <20200318195038.GA7123@alvherre.pgsql> <1ab609c9-2c16-26ff-5fbe-c3195e541f9c@amazon.com> <6e1dda09-0c4f-b196-a589-fb741f11686f@amazon.com> From: "Drouvot, Bertrand" Message-ID: Date: Mon, 22 Mar 2021 15:57:58 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------B973B848184E6E81F279C079" Content-Language: en-US X-Originating-IP: [10.43.161.41] X-ClientProxiedBy: EX13D05UWB001.ant.amazon.com (10.43.161.181) To EX13D03EUC003.ant.amazon.com (10.43.164.192) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --------------B973B848184E6E81F279C079 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 3/22/21 3:10 PM, Fabrízio de Royes Mello wrote: > > *CAUTION*: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > On Thu, Mar 18, 2021 at 5:34 AM Drouvot, Bertrand > wrote: > > > > Thanks! > > > > Just made minor changes to make it compiling again on current master > (mainly had to take care of > ResolveRecoveryConflictWithSnapshotFullXid() that has been introduced > in e5d8a99903). > > > > Please find enclosed the new patch version that currently passes > "make check" and the 2 associated TAP tests. > > > > Unfortunately it still not applying to the current master: > > $ git am ~/Downloads/v10-000*.patch > Applying: Allow logical decoding on standby. > Applying: Add info in WAL records in preparation for logical slot > conflict handling. > error: patch failed: src/backend/access/nbtree/nbtpage.c:32 > error: src/backend/access/nbtree/nbtpage.c: patch does not apply > Patch failed at 0002 Add info in WAL records in preparation for > logical slot conflict handling. > hint: Use 'git am --show-current-patch' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". oh Indeed, it's moving so fast! Let me rebase it (It was already my plan to do so as I have observed during the week end that the v7-0003-Handle-logical-slot-conflicts-on-standby.patch introduced incorrect changes (that should not be there at all in ReplicationSlotReserveWal()) that have been kept in v8, v9 and v10. > > > > I'll have a look to the whole thread to check if there is anything > else waiting in the pipe regarding this feature, unless some of you > know off the top of their head? > > > > Will do the same!!! Thanks! > But as far I remember last time I checked it everything discussed is > covered in this patch set. That's also what I have observed so far. Bertrand --------------B973B848184E6E81F279C079 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit


On 3/22/21 3:10 PM, Fabrízio de Royes Mello wrote:

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.


On Thu, Mar 18, 2021 at 5:34 AM Drouvot, Bertrand <bdrouvot@amazon.com> wrote:
>
> Thanks!
>
> Just made minor changes to make it compiling again on current master (mainly had to take care of ResolveRecoveryConflictWithSnapshotFullXid() that has been introduced in e5d8a99903).
>
> Please find enclosed the new patch version that currently passes "make check" and the 2 associated TAP tests.
>

Unfortunately it still not applying to the current master:

$ git am ~/Downloads/v10-000*.patch                                                    
Applying: Allow logical decoding on standby.
Applying: Add info in WAL records in preparation for logical slot conflict handling.
error: patch failed: src/backend/access/nbtree/nbtpage.c:32
error: src/backend/access/nbtree/nbtpage.c: patch does not apply
Patch failed at 0002 Add info in WAL records in preparation for logical slot conflict handling.
hint: Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

oh Indeed, it's moving so fast!

Let me rebase it (It was already my plan to do so as I have observed during the week end that the v7-0003-Handle-logical-slot-conflicts-on-standby.patch introduced incorrect changes (that should not be there at all in ReplicationSlotReserveWal()) that have been kept in v8, v9 and v10.



> I'll have a look to the whole thread to check if there is anything else waiting in the pipe regarding this feature, unless some of you know off the top of their head?
>

Will do the same!!!

Thanks!


But as far I remember last time I checked it everything discussed is covered in this patch set.

That's also what I have observed so far.

Bertrand


--------------B973B848184E6E81F279C079--