Content-Type: multipart/mixed; boundary="------------4cSLkyHaNSlGawBinNXrlomZ"
Message-ID: <b187a7cf-d4e3-5a32-4d01-8383677797f3@oss.nttdata.com>
Date: Thu, 21 Jul 2022 23:22:26 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Content-Language: en-US
To: pgsql-hackers@postgresql.org
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Subject: postgres_fdw: Fix bug in checking of return value of PQsendQuery().
Archived-At: 
 <https://www.postgresql.org/message-id/b187a7cf-d4e3-5a32-4d01-8383677797f3%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------4cSLkyHaNSlGawBinNXrlomZ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I found that fetch_more_data_begin() in postgres_fdw reports an error when PQsendQuery() returns the value less than 0 as follows though PQsendQuery() can return only 1 or 0. I think this is  a bug. Attached is the patch that fixes this bug. This needs to be back-ported to v14 where async execution was supported in postgres_fdw.

	if (PQsendQuery(fsstate->conn, sql) < 0)
		pgfdw_report_error(ERROR, NULL, fsstate->conn, false, fsstate->query);

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
--------------4cSLkyHaNSlGawBinNXrlomZ
Content-Type: text/plain; charset=UTF-8;
 name="0001-postgres_fdw-Fix-bug-in-checking-of-return-value-of-.patch"
Content-Disposition: attachment;
 filename*0="0001-postgres_fdw-Fix-bug-in-checking-of-return-value-of-.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA1MzhmMzNhMTdmMzYyM2NlYzU0NzY4YTczMjVkNjRmOGU5N2FiZTA2IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFRodSwgMjEgSnVsIDIwMjIgMjI6NTI6NTAgKzA5MDAKU3ViamVjdDogW1BB
VENIXSBwb3N0Z3Jlc19mZHc6IEZpeCBidWcgaW4gY2hlY2tpbmcgb2YgcmV0dXJuIHZhbHVl
IG9mCiBQUXNlbmRRdWVyeSgpLgoKV2hlbiBwb3N0Z3Jlc19mZHcgYmVnaW5zIGFuIGFzeW5j
aHJvbm91cyBkYXRhIGZldGNoLCBpdCBzdWJtaXRzIEZFVENIIHF1ZXJ5CmJ5IHVzaW5nIFBR
c2VuZFF1ZXJ5KCkuIElmIFBRc2VuZFF1ZXJ5KCkgZmFpbHMgYW5kIHJldHVybnMgMCwgcG9z
dGdyZXNfZmR3CnNob3VsZCByZXBvcnQgYW4gZXJyb3IuIEJ1dCwgcHJldmlvdXNseSwgcG9z
dGdyZXNfZmR3IHJlcG9ydGVkIGFuIGVycm9yCm9ubHkgd2hlbiB0aGUgcmV0dXJuIHZhbHVl
IGlzIGxlc3MgdGhhbiAwLCB0aG91Z2ggUFFzZW5kUXVlcnkoKSBuZXZlciByZXR1cm4KdGhl
IHZhbHVlcyBvdGhlciB0aGFuIDAgYW5kIDEuIFRoZXJlZm9yZSBwb3N0Z3Jlc19mZHcgY291
bGQgbm90IGhhbmRsZQp0aGUgZmFpbHVyZSB0byBzZW5kIEZFVENIIHF1ZXJ5IGluIGFuIGFz
eW5jaHJvbm91cyBkYXRhIGZldGNoLgoKVGhpcyBjb21taXQgZml4ZXMgcG9zdGdyZXNfZmR3
IHNvIHRoYXQgaXQgcmVwb3J0cyBhbiBlcnJvcgp3aGVuIFBRc2VuZFF1ZXJ5KCkgcmV0dXJu
cyAwLgoKQmFjay1wYXRjaCB0byB2MTQgd2hlcmUgYXN5bmNocm9ub3VzIGV4ZWN1dGlvbiB3
YXMgc3VwcG9ydGVkIGluIHBvc3RncmVzX2Zkdy4KCkF1dGhvcjogRnVqaWkgTWFzYW8KUmV2
aWV3ZWQtYnk6CkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vCi0tLQogY29udHJp
Yi9wb3N0Z3Jlc19mZHcvcG9zdGdyZXNfZmR3LmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwg
MSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9jb250cmliL3Bv
c3RncmVzX2Zkdy9wb3N0Z3Jlc19mZHcuYyBiL2NvbnRyaWIvcG9zdGdyZXNfZmR3L3Bvc3Rn
cmVzX2Zkdy5jCmluZGV4IGYzYjkzOTU0ZWUuLjA0OGRiNTQyZDMgMTAwNjQ0Ci0tLSBhL2Nv
bnRyaWIvcG9zdGdyZXNfZmR3L3Bvc3RncmVzX2Zkdy5jCisrKyBiL2NvbnRyaWIvcG9zdGdy
ZXNfZmR3L3Bvc3RncmVzX2Zkdy5jCkBAIC03MDcwLDcgKzcwNzAsNyBAQCBmZXRjaF9tb3Jl
X2RhdGFfYmVnaW4oQXN5bmNSZXF1ZXN0ICphcmVxKQogCXNucHJpbnRmKHNxbCwgc2l6ZW9m
KHNxbCksICJGRVRDSCAlZCBGUk9NIGMldSIsCiAJCQkgZnNzdGF0ZS0+ZmV0Y2hfc2l6ZSwg
ZnNzdGF0ZS0+Y3Vyc29yX251bWJlcik7CiAKLQlpZiAoUFFzZW5kUXVlcnkoZnNzdGF0ZS0+
Y29ubiwgc3FsKSA8IDApCisJaWYgKCFQUXNlbmRRdWVyeShmc3N0YXRlLT5jb25uLCBzcWwp
KQogCQlwZ2Zkd19yZXBvcnRfZXJyb3IoRVJST1IsIE5VTEwsIGZzc3RhdGUtPmNvbm4sIGZh
bHNlLCBmc3N0YXRlLT5xdWVyeSk7CiAKIAkvKiBSZW1lbWJlciB0aGF0IHRoZSByZXF1ZXN0
IGlzIGluIHByb2Nlc3MgKi8KLS0gCjIuMzYuMAoK

--------------4cSLkyHaNSlGawBinNXrlomZ--