Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5I57-0008Vd-W4 for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Dec 2022 03:05:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p5I55-00084v-Vt for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Dec 2022 03:05:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5I55-00083X-Mo for pgsql-hackers@lists.postgresql.org; Wed, 14 Dec 2022 03:05:15 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p5I53-0007oi-Dw for pgsql-hackers@postgresql.org; Wed, 14 Dec 2022 03:05:14 +0000 Received: by mail-pl1-x630.google.com with SMTP id p24so1997470plw.1 for ; Tue, 13 Dec 2022 19:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=2O5FWN7egmXvG9d/Qx/abosw7PrThobeRpcdCsV1vrA=; b=AXuHEWcB4p71UeZS5Srx6VJ0mXV67cXOr9agkaj0HaP0QaeiuB/3TK8Gs62Qj86UNU 10xbrHCJs7jLDhyKpO3+nA2mbBDXBv6xNhOPh+sRsB2tCpvEDGWlJv1CaMh1++AvpHeN NeLAsnW5R0M4DDpDOwNABpcUushQS94wqs2+VQkxarL1bQ+kUpCdQLHmwShIQMSi1PTk z5Iw2TCLnOW1SV0X6Eg7C02QEx83bQWETtXFoI3HeEJD1tlUTMhR7zuRDJwNtjKHZZWY oGTs4QOmY0/kmE/u9m1GSvgy6D7+56nkmueqhmG61D8lL0ENkyfQ7w3hOeGyByVCVLcV uz1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2O5FWN7egmXvG9d/Qx/abosw7PrThobeRpcdCsV1vrA=; b=7qpi3mZMVssLPRR8+zziCDt/jnIUoEvhKIT4QIK1TGdyGzQf1KlyOqteCYDzxH3w/A TwwykZh1hvIKCR1bpkalDjDNR5LkuerAOahHqB8f2QgxXM6eIOXi3Uf363MbRHzcjf8p 4yGv9AsH+XS1vOcUUAbyfMinuNH5IFLZcoaNX1UVHjgxXwlS5wf8nAhlD33KW1MVYf1i I14/+nywj/idZbl+h7kR6cjxuogJd51F4aCMcKpUuI2i144sPUSgZKpORcbCi+oXwrVo 4xLw/y6rgolX+imCa8188hpxL5A3Z9kabnHsHW7MsOhekXxjYcoQSX3yi8lWHqpyn54z TP9g== X-Gm-Message-State: ANoB5pmfi0tOxqAhoSItrRfa9ih0Ajtcb044QayFcuQfDPLylOiE6wmy XzujPiXbHZEgQLRzXHEI0vYot/zxq150zpOq X-Google-Smtp-Source: AA0mqf4LzXK0TfqhT6uJVpcLoC4H9zPn59WCubZJnJ8Tsy4q6OH53Z6zzYvVWSzxRQYvfaSx+RPxhg== X-Received: by 2002:a17:902:f24a:b0:189:9031:6761 with SMTP id j10-20020a170902f24a00b0018990316761mr21075015plc.22.1670987112275; Tue, 13 Dec 2022 19:05:12 -0800 (PST) Received: from [172.18.7.9] ([12.126.244.130]) by smtp.gmail.com with ESMTPSA id 12-20020a170902c20c00b00186abb95bfdsm625375pll.25.2022.12.13.19.05.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 19:05:11 -0800 (PST) Message-ID: Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX From: Jeff Davis To: Nathan Bossart Cc: pgsql-hackers@postgresql.org Date: Tue, 13 Dec 2022 19:05:10 -0800 In-Reply-To: <20221212210136.GA449764@nathanxps13> References: <20221208183707.GA55474@nathanxps13> <210dc2cc663934f8b463e4effa9af86225e46ce4.camel@j-davis.com> <20221210204109.GA197392@nathanxps13> <20221212200427.GA448418@nathanxps13> <20221212210136.GA449764@nathanxps13> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, 2022-12-12 at 13:01 -0800, Nathan Bossart wrote: > On Mon, Dec 12, 2022 at 12:04:27PM -0800, Nathan Bossart wrote: > > Patch attached.=C2=A0 I ended up reverting some parts of the > > VACUUM/ANALYZE > > patch that were no longer needed (i.e., if the user doesn't have > > permission > > to VACUUM, we don't need to separately check whether the user has > > permission to ANALYZE).=C2=A0 Otherwise, I don't think there's anything > > tremendously different between v1 and v2 besides the fact that all > > the > > privileges are grouped together. >=20 > Here is a v3 of the patch that fixes a typo in the docs. Committed. The only significant change is that it also allows LOCK TABLE if you have the MAINTAIN privilege. I noticed a couple issues unrelated to your patch, and started separate patch threads[1][2]. [1]=20 https://www.postgresql.org/message-id/c0a85c2e83158560314b576b6241c8ed0aea1= 745.camel@j-davis.com [2] https://www.postgresql.org/message-id/9550c76535404a83156252b25a11babb4792e= a1e.camel@j-davis.com --=20 Jeff Davis PostgreSQL Contributor Team - AWS