Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qnGaf-00AMUW-M2 for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Oct 2023 10:55:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qnGae-00AnMB-7j for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Oct 2023 10:55:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qnGad-00AnM2-Om for pgsql-hackers@lists.postgresql.org; Mon, 02 Oct 2023 10:55:51 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qnFLA-007l2g-DP for pgsql-hackers@lists.postgresql.org; Mon, 02 Oct 2023 09:35:54 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3247cefa13aso5879771f8f.1 for ; Mon, 02 Oct 2023 02:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696239347; x=1696844147; darn=lists.postgresql.org; h=to:subject:from:cc:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=FJiQj/QyvLvjDZmKaUqXs4ZTbO08zJ4/w0AlpcVAzgI=; b=AF/BUZTFnFDwImYf9AS286L9YlyyCx5Rge2RMyG50wdDDGAiAa3Wgb/hMHDfJj0lcT TFdS4tEOSij7mgvXe85UDSIPphe0EHZyMonN1iFpyeEBTW8AqcQfsbA+IdIwV2pxnAyf rGBKUEQbTbadS29FTlQmUyt3QLIN4ygvH9CWS3szSwY7sca440osvXmv4MxdzF9u3L/r qMlNGf5cP6lom2zu1RhpPwlpnBmmbgp3grgIMwe1I77AquX/BzfAIaJ9LRzcBd3hGbMd Xn1Mxi7EZvzD1Qqf6QUjQ///7oP6ePU+A7l+niUJlvic4y2p4x3auBoAg6g3fGKQzGGb S/JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696239347; x=1696844147; h=to:subject:from:cc:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FJiQj/QyvLvjDZmKaUqXs4ZTbO08zJ4/w0AlpcVAzgI=; b=wZVJZO+JR1opPL02lJGs27zkJfQZUlnlO5EKp3MzPnmSfuljo5mpDLgyfag81HbamT upLF2gApAd/NX0qPcCeIBu8pKX3FOnQDBmYP0U0LddeKxOUF72YUOUxbi22m8vnp2Vlv ZMjjgiPRn/Pk2TWu1I531yiMKIr8KQCnraBVkCgcNVXMrKLFDSkr8kbphr8/rJVbblaK at1FNNf82OhqTzD6ry7KsKIxJErEgCUjEn1vXq2ACBMkLSHQLkHdib55zSEVatclTno8 5FXi6Mu8gGkdDbDvUc1zQEu4nXvfHir6FIf3eblKAXI6tJObUwOUlRGHYlrUwdiTtKuv wZtA== X-Gm-Message-State: AOJu0Ywcv3uab544QOMdoiDJj57lD7W05+hoY+KCuunDRcDPX61bn/s/ EW0iN3405Z5edUKAKPmJwY4MfGKqyg8= X-Google-Smtp-Source: AGHT+IHC7ji3W5Y+SlAdum3oCMQvA6dIHNtZ6M4xpMXZSbxqzc3Lb6YGKfXMhkKn/PVemPu+cKmoog== X-Received: by 2002:a5d:55c1:0:b0:323:3346:7d51 with SMTP id i1-20020a5d55c1000000b0032333467d51mr9419682wrw.18.1696239346418; Mon, 02 Oct 2023 02:35:46 -0700 (PDT) Received: from ?IPV6:2a01:cb11:55e:1700:fdfb:2c20:5a8d:9c46? ([2a01:cb11:55e:1700:fdfb:2c20:5a8d:9c46]) by smtp.gmail.com with ESMTPSA id ay13-20020a5d6f0d000000b003179b3fd837sm20530093wrb.33.2023.10.02.02.35.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 02:35:45 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------bdJJoA7pvciDcVOYz1qhnUml" Message-ID: Date: Mon, 2 Oct 2023 11:35:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US Cc: Michael Paquier From: "Drouvot, Bertrand" Subject: Replace (stat())[7] in TAP tests with -s To: PostgreSQL Hackers List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------bdJJoA7pvciDcVOYz1qhnUml Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi hackers, Please find attached a tiny patch to $SUBJECT. It: - provides more consistency to the way we get files size in TAP tests - seems more elegant that relying on a hardcoded result position Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com --------------bdJJoA7pvciDcVOYz1qhnUml Content-Type: text/plain; charset=UTF-8; name="v1-0001-Be-consistent-in-TAP-tests-for-the-way-we-get-fil.patch" Content-Disposition: attachment; filename*0="v1-0001-Be-consistent-in-TAP-tests-for-the-way-we-get-fil.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBhMjI3ZWI5NTdjYTMyZGNiMWI1M2E3Nzg2OTkyNzMyYjFkMDJjMTMwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJ0cmFuZCBEcm91dm90IDxiZXJ0cmFuZGRyb3V2 b3QucGdAZ21haWwuY29tPgpEYXRlOiBNb24sIDIgT2N0IDIwMjMgMDk6MDE6MjAgKzAwMDAK U3ViamVjdDogW1BBVENIIHYxXSBCZSBjb25zaXN0ZW50IGluIFRBUCB0ZXN0cyBmb3IgdGhl IHdheSB3ZSBnZXQgZmlsZXMgc2l6ZQoKVXNpbmcgLXMgaXMgbWFpbmx5IHVzZWQgdG8gZ2V0 IGZpbGVzIHNpemUgYnV0IHRoZXJlIGlzIHNvbWUgcGxhY2VzIG1ha2luZyB1c2UKb2YgInN0 YXQiIGFuZCBpdHMgN3RoIHJlc3VsdCBwb3NpdGlvbi4KClJlcGxhY2luZyB0aG9zZSBieSAt cyBpbnN0ZWFkIGFzIGl0J3MgbW9yZSBlbGVnYW50IHRoYW4gcmVseWluZyBvbiB0aGlzIGhh cmRjb2RlZAo3dGggcG9zaXRpb24uCi0tLQogc3JjL2Jpbi9wZ19jb250cm9sZGF0YS90LzAw MV9wZ19jb250cm9sZGF0YS5wbCB8ICAyICstCiBzcmMvYmluL3BnX3Jlc2V0d2FsL3QvMDAy X2NvcnJ1cHRlZC5wbCAgICAgICAgIHwgIDIgKy0KIHNyYy90ZXN0L3JlY292ZXJ5L3QvMDE5 X3JlcGxzbG90X2xpbWl0LnBsICAgICAgfCAxNCArKystLS0tLS0tLS0tLQogMyBmaWxlcyBj aGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQogIDEyLjUlIHNyYy9i aW4vcGdfY29udHJvbGRhdGEvdC8KICAxMi41JSBzcmMvYmluL3BnX3Jlc2V0d2FsL3QvCiAg NzQuOCUgc3JjL3Rlc3QvcmVjb3ZlcnkvdC8KCmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX2Nv bnRyb2xkYXRhL3QvMDAxX3BnX2NvbnRyb2xkYXRhLnBsIGIvc3JjL2Jpbi9wZ19jb250cm9s ZGF0YS90LzAwMV9wZ19jb250cm9sZGF0YS5wbAppbmRleCA0OTE4ZWE4OTQ0Li45ZGI4MDE1 ZDBiIDEwMDY0NAotLS0gYS9zcmMvYmluL3BnX2NvbnRyb2xkYXRhL3QvMDAxX3BnX2NvbnRy b2xkYXRhLnBsCisrKyBiL3NyYy9iaW4vcGdfY29udHJvbGRhdGEvdC8wMDFfcGdfY29udHJv bGRhdGEucGwKQEAgLTI0LDcgKzI0LDcgQEAgY29tbWFuZF9saWtlKFsgJ3BnX2NvbnRyb2xk YXRhJywgJG5vZGUtPmRhdGFfZGlyIF0sCiAjIGNoZWNrIHdpdGggYSBjb3JydXB0ZWQgcGdf Y29udHJvbAogCiBteSAkcGdfY29udHJvbCA9ICRub2RlLT5kYXRhX2RpciAuICcvZ2xvYmFs L3BnX2NvbnRyb2wnOwotbXkgJHNpemUgPSAoc3RhdCgkcGdfY29udHJvbCkpWzddOworbXkg JHNpemUgPSAtcyAkcGdfY29udHJvbDsKIAogb3BlbiBteSAkZmgsICc+JywgJHBnX2NvbnRy b2wgb3IgQkFJTF9PVVQoJCEpOwogYmlubW9kZSAkZmg7CmRpZmYgLS1naXQgYS9zcmMvYmlu L3BnX3Jlc2V0d2FsL3QvMDAyX2NvcnJ1cHRlZC5wbCBiL3NyYy9iaW4vcGdfcmVzZXR3YWwv dC8wMDJfY29ycnVwdGVkLnBsCmluZGV4IDZkMTlhMWVmZDUuLmIzYTM3NzI4YTQgMTAwNjQ0 Ci0tLSBhL3NyYy9iaW4vcGdfcmVzZXR3YWwvdC8wMDJfY29ycnVwdGVkLnBsCisrKyBiL3Ny Yy9iaW4vcGdfcmVzZXR3YWwvdC8wMDJfY29ycnVwdGVkLnBsCkBAIC0xNCw3ICsxNCw3IEBA IG15ICRub2RlID0gUG9zdGdyZVNRTDo6VGVzdDo6Q2x1c3Rlci0+bmV3KCdtYWluJyk7CiAk bm9kZS0+aW5pdDsKIAogbXkgJHBnX2NvbnRyb2wgPSAkbm9kZS0+ZGF0YV9kaXIgLiAnL2ds b2JhbC9wZ19jb250cm9sJzsKLW15ICRzaXplID0gKHN0YXQoJHBnX2NvbnRyb2wpKVs3XTsK K215ICRzaXplID0gLXMgJHBnX2NvbnRyb2w7CiAKICMgUmVhZCBvdXQgdGhlIGhlYWQgb2Yg dGhlIGZpbGUgdG8gZ2V0IFBHX0NPTlRST0xfVkVSU0lPTiBpbgogIyBwYXJ0aWN1bGFyLgpk aWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMTlfcmVwbHNsb3RfbGltaXQucGwg Yi9zcmMvdGVzdC9yZWNvdmVyeS90LzAxOV9yZXBsc2xvdF9saW1pdC5wbAppbmRleCAzM2U1 MGFkOTMzLi43ZDk0ZjE1Nzc4IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWNvdmVyeS90LzAx OV9yZXBsc2xvdF9saW1pdC5wbAorKysgYi9zcmMvdGVzdC9yZWNvdmVyeS90LzAxOV9yZXBs c2xvdF9saW1pdC5wbApAQCAtMTczLDcgKzE3Myw3IEBAICRub2RlX3ByaW1hcnktPnNhZmVf cHNxbCgncG9zdGdyZXMnLAogCSJBTFRFUiBTWVNURU0gU0VUIG1heF93YWxfc2l6ZT0nNDBN Qic7IFNFTEVDVCBwZ19yZWxvYWRfY29uZigpIik7CiAKICMgQWR2YW5jZSBXQUwgYWdhaW4u IFRoZSBzbG90IGxvc2VzIHRoZSBvbGRlc3Qgc2VnbWVudCBieSB0aGUgbmV4dCBjaGVja3Bv aW50Ci1teSAkbG9nc3RhcnQgPSBnZXRfbG9nX3NpemUoJG5vZGVfcHJpbWFyeSk7CitteSAk bG9nc3RhcnQgPSAtcyAkbm9kZV9wcmltYXJ5LT5sb2dmaWxlOwogYWR2YW5jZV93YWwoJG5v ZGVfcHJpbWFyeSwgNyk7CiAKICMgTm93IGNyZWF0ZSBhbm90aGVyIGNoZWNrcG9pbnQgYW5k IHdhaXQgdW50aWwgdGhlIFdBUk5JTkcgaXMgaXNzdWVkCkBAIC0yMjksNyArMjI5LDcgQEAg JG5vZGVfcHJpbWFyeS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCiBpcygkb2xkZXN0c2VnLCAk cmVkb3NlZywgImNoZWNrIHRoYXQgc2VnbWVudHMgaGF2ZSBiZWVuIHJlbW92ZWQiKTsKIAog IyBUaGUgc3RhbmRieSBubyBsb25nZXIgY2FuIGNvbm5lY3QgdG8gdGhlIHByaW1hcnkKLSRs b2dzdGFydCA9IGdldF9sb2dfc2l6ZSgkbm9kZV9zdGFuZGJ5KTsKKyRsb2dzdGFydCA9IC1z ICRub2RlX3N0YW5kYnktPmxvZ2ZpbGU7CiAkbm9kZV9zdGFuZGJ5LT5zdGFydDsKIAogbXkg JGZhaWxlZCA9IDA7CkBAIC0zNjgsNyArMzY4LDcgQEAgbXkgJHJlY2VpdmVycGlkID0gJG5v ZGVfc3RhbmRieTMtPnNhZmVfcHNxbCgncG9zdGdyZXMnLAogCSJTRUxFQ1QgcGlkIEZST00g cGdfc3RhdF9hY3Rpdml0eSBXSEVSRSBiYWNrZW5kX3R5cGUgPSAnd2FscmVjZWl2ZXInIik7 CiBsaWtlKCRyZWNlaXZlcnBpZCwgcXIvXlswLTldKyQvLCAiaGF2ZSB3YWxyZWNlaXZlciBw aWQgJHJlY2VpdmVycGlkIik7CiAKLSRsb2dzdGFydCA9IGdldF9sb2dfc2l6ZSgkbm9kZV9w cmltYXJ5Myk7CiskbG9nc3RhcnQgPSAtcyAkbm9kZV9wcmltYXJ5My0+bG9nZmlsZTsKICMg ZnJlZXplIHdhbHNlbmRlciBhbmQgd2FscmVjZWl2ZXIuIFNsb3Qgd2lsbCBzdGlsbCBiZSBh Y3RpdmUsIGJ1dCB3YWxyZWNlaXZlcgogIyB3b24ndCBnZXQgYW55dGhpbmcgYW55bW9yZS4K IGtpbGwgJ1NUT1AnLCAkc2VuZGVycGlkLCAkcmVjZWl2ZXJwaWQ7CkBAIC00MzMsMTIgKzQz Myw0IEBAIHN1YiBhZHZhbmNlX3dhbAogCXJldHVybjsKIH0KIAotIyByZXR1cm4gdGhlIHNp emUgb2YgbG9nZmlsZSBvZiAkbm9kZSBpbiBieXRlcwotc3ViIGdldF9sb2dfc2l6ZQotewot CW15ICgkbm9kZSkgPSBAXzsKLQotCXJldHVybiAoc3RhdCAkbm9kZS0+bG9nZmlsZSlbN107 Ci19Ci0KIGRvbmVfdGVzdGluZygpOwotLSAKMi4zNC4xCgo= --------------bdJJoA7pvciDcVOYz1qhnUml--