Feedback-ID: i131946ab:Fastmail
Message-ID: <b2437a6f-b083-5abe-6bdf-f5968a666992@enterprisedb.com>
Date: Wed, 12 Apr 2023 17:30:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: meson documentation build open issues
Content-Language: en-US
To: Andrew Dunstan <andrew@dunslane.net>, Andres Freund <andres@anarazel.de>,
 Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <3fc3bb9b-f7f8-d442-35c1-ec82280c564a@enterprisedb.com>
 <7137c5b3-7d9e-4659-03a2-9e2df74cbab7@enterprisedb.com>
 <20230405144512.zfzb6vd77dk5dnyr@awork3.anarazel.de>
 <50193d79-e7d1-ea81-1ef3-5670b007c7c3@enterprisedb.com>
 <c3e12a10-5824-f9c7-ad09-c66720df7b2d@dunslane.net>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <c3e12a10-5824-f9c7-ad09-c66720df7b2d@dunslane.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/b2437a6f-b083-5abe-6bdf-f5968a666992%40enterprisedb.com>
Precedence: bulk

On 07.04.23 16:39, Andrew Dunstan wrote:
>>>>> 5. There doesn't appear to be an equivalent of "make world" and "make
>>>>> install-world" that includes documentation builds.
>>>>
>>>> This has been addressed with the additional meson auto options.  But it
>>>> seems that these options only control building, not installing, so 
>>>> there is
>>>> no "install-world" aspect yet.
>>>
>>> I'm not following - install-world install docs if the docs feature is
>>> available, and not if not?
>>
>> I had expected that if meson setup enables the 'docs' feature, then 
>> meson compile will build the documentation, which happens, and meson 
>> install will install it, which does not happen.
> 
> "meson compile" doesn't seem to build the docs by default ( see 
> <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2023-04-06%2018%3A17%3A04&stg=build>), and I'd rather it didn't, building the docs is a separate and optional step for the buildfarm.

You can control this with the "docs" option for meson, as of recently.