Subject: Re: Reviewing freeze map code
To: Andres Freund <andres@anarazel.de>
References: <20160629170050.zpvcmaz3ni2y75d7@alap3.anarazel.de>
 <CAA4eK1+-Zjmb7mcHkQzWpQ_DOc3vAp0e0Bucx36gutp+Z-tjBQ@mail.gmail.com>
 <20160630034317.r7axkleum65u6t2l@alap3.anarazel.de>
 <CAA4eK1+19nb50V1tGRj93pvTK=pf9F0Xcp-xam9GsMwO4HuugQ@mail.gmail.com>
 <CAD21AoB4qeuCS=GeT3brf_fwcgMj+G0vKJvKqEsH1EzU699Fag@mail.gmail.com>
 <CAA4eK1K0aPO4tedf4X0fA6xoVB87PW-Z8dFFY+8Fo2r+AwfFBw@mail.gmail.com>
 <CAD21AoBgYuA2RM6+fYpYU1HT=Po9bOFytO43uUtoUe00UyASfg@mail.gmail.com>
 <CA+TgmoY8PdS9TxH35_OH9003_BYPj3_E14LiN6Kk5Ad8r_wi8A@mail.gmail.com>
 <20160701192351.s6revshsn2ir4szq@alap3.anarazel.de>
 <c954f72f-6900-346e-d2fc-e9a7a3d0efcf@BlueTreble.com>
 <20160701204329.7bvfy2fu47fn4fjp@alap3.anarazel.de>
CC: Robert Haas <robertmhaas@gmail.com>, Masahiko Sawada
	<sawada.mshk@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Alvaro
 Herrera <alvherre@2ndquadrant.com>, Thomas Munro
	<thomas.munro@enterprisedb.com>, Stephen Frost <sfrost@snowman.net>, Michael
 Paquier <michael.paquier@gmail.com>, "pgsql-hackers@postgresql.org"
	<pgsql-hackers@postgresql.org>
From: Jim Nasby <Jim.Nasby@BlueTreble.com>
Message-ID: <b24fecf9-6dfb-89b7-904c-bef387025614@BlueTreble.com>
Date: Fri, 1 Jul 2016 15:49:04 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <20160701204329.7bvfy2fu47fn4fjp@alap3.anarazel.de>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: bluetreble.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2016 20:49:10.1085 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR11MB0688
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 7/1/16 3:43 PM, Andres Freund wrote:
> On 2016-07-01 15:42:22 -0500, Jim Nasby wrote:
>> On 7/1/16 2:23 PM, Andres Freund wrote:
>>>>> The only
>>>>> cost of that is that vacuum will come along and mark the page
>>>>> all-visible again instead of skipping it, but that's probably not an
>>>>> enormous expense in most cases.
>>> I think the main cost is not having the page marked as all-visible for
>>> index-only purposes. If it's an insert mostly table, it can be a long
>>> while till vacuum comes around.
>>
>> ISTM that's something that should be addressed anyway (and separately), no?
>
> Huh? That's the current behaviour in heap_lock_tuple.

Oh, I was referring to autovac not being aggressive enough on 
insert-mostly tables. Certainly if there's a reasonable way to avoid 
invalidating the VM when locking a tuple that'd be good.
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)   mobile: 512-569-9461


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers