Subject: Re: Column Filtering in Logical Replication
To: vignesh C <vignesh21@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Rahila Syed <rahilasyed90@gmail.com>, Peter Smith <smithpb2250@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: 
 <CAA4eK1Ka0i7rH4DSafEhsOuo+O80S5Ga-ZjRQeYgh+bPR7hT-Q@mail.gmail.com>
 <202109151150.2gbvjmwvgoin@alvherre.pgsql>
 <CALDaNm1YoxJCs=uiyPM=tFDDc2qn0ja01nb2TCPqrjZH2jR0sQ@mail.gmail.com>
 <b143a80b-7b9c-394c-f618-874eaa3f2a12@enterprisedb.com>
 <CAA4eK1KcvPhWBv3LMY5ntpUK9DooP0DQmeGvNPwpts9YOfPd3w@mail.gmail.com>
 <CALDaNm3hNhwhyPqx_qPpme1j=yujaZmyF0Z-JaF2BjpxNzL6Hg@mail.gmail.com>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
Message-ID: <b26e44cd-67b6-24d0-f0c3-f24793dbf7af@enterprisedb.com>
Date: Fri, 24 Sep 2021 22:54:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: 
 <CALDaNm3hNhwhyPqx_qPpme1j=yujaZmyF0Z-JaF2BjpxNzL6Hg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b26e44cd-67b6-24d0-f0c3-f24793dbf7af%40enterprisedb.com>
Precedence: bulk


On 9/24/21 7:05 AM, vignesh C wrote:
> On Fri, Sep 24, 2021 at 8:40 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> On Fri, Sep 24, 2021 at 12:45 AM Tomas Vondra
>> <tomas.vondra@enterprisedb.com> wrote:
>>>
>>> Hi,
>>>
>>> I wanted to do a review of this patch, but I'm a bit confused about
>>> which patch(es) to review. There's the v5 patch, and then these two
>>> patches - which seem to be somewhat duplicate, though.
>>>
>>> Can anyone explain what's the "current" patch version, or perhaps tell
>>> me which of the patches to combine?
>>>
>>
>> I think v5 won't work atop a common grammar patch. There need some
>> adjustments in v5. I think it would be good if we can first get the
>> common grammar patch reviewed/committed and then build this on top of
>> it. The common grammar and the corresponding implementation are being
>> accomplished in the Schema support patch, the latest version of which
>> is at [1].
> 
> I have posted an updated patch with the fixes at [1], please review
> the updated patch.
> [1] - https://www.postgresql.org/message-id/CALDaNm1R-xbQvz4LU5OXu3KKwbWOz3uDcT_YjRU6V0R5FZDYDg%40mail.gmail.com
> 

But that's not the column filtering patch, right? Why would this patch 
depend on "schema level support", but maybe the consensus is there's 
some common part that we need to get in first?

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company