Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGKT9-0004xK-8n for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Jul 2023 14:23:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qGKT7-00015q-AR for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Jul 2023 14:23:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGKT7-00015h-17 for pgsql-hackers@lists.postgresql.org; Mon, 03 Jul 2023 14:23:57 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qGKT4-001xxb-LP for pgsql-hackers@lists.postgresql.org; Mon, 03 Jul 2023 14:23:56 +0000 X-GND-Sasl: vik@postgresfriends.org X-GND-Sasl: vik@postgresfriends.org Received: by mail.gandi.net (Postfix) with ESMTPSA id C8F6D40009; Mon, 3 Jul 2023 14:23:50 +0000 (UTC) Message-ID: Date: Mon, 3 Jul 2023 16:23:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: Add support for AT LOCAL To: Daniel Gustafsson Cc: PostgreSQL Hackers References: <8e25dec4-5667-c1a5-6581-167d710c2182@postgresfriends.org> Content-Language: en-US From: Vik Fearing In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 7/3/23 15:42, Daniel Gustafsson wrote: >> On 6 Jun 2023, at 05:13, Vik Fearing wrote: > >> Patch against 3f1aaaa180 attached. > > This patch fails to compile, the declaration of variables in the switch block > needs to be scoped within a { } block. Interesting. It compiles for me. > I've fixed this trivial error in the > attached v2 and also reflowed the comments which now no longer fit. Thank you. -- Vik Fearing