public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Tom Lane <[email protected]>
Cc: Melanie Plageman <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: commitfest.postgresql.org is no longer fit for purpose
Date: Fri, 17 May 2024 00:03:30 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CA+TgmobnTcNq1xQE_+jxBEtj+AjKg0r_p5YNFHDE+EDnpcpFxA@mail.gmail.com>
	<CAAKRu_Yx8utYpBOfmHdqLB64KjEGUsQG8j0ZGNNUS8_8vHbSbw@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On 16.05.24 23:46, Tom Lane wrote:
> Peter Eisentraut <[email protected]> writes:
>> The problem is if we have 180 patches in Needs Review, and only 20 are
>> really actually ready to be reviewed.  And a second-order problem is
>> that if you already know that this will be the case, you give up before
>> even looking.
> 
> Right, so what can we do about that?  Does Needs Review state need to
> be subdivided, and if so how?

Maybe a new state "Unclear".  Then a commitfest manager, or someone like 
Robert just now, can more easily power through the list and set 
everything that's doubtful to Unclear, with the understanding that the 
author can set it back to Needs Review to signal that they actually 
think it's ready.  Or, as a variant of what someone else was saying, 
just set all patches that carry over from March to July as Unclear.  Or 
something like that.

I think, if we consider the core mission of the commitfest app, we need 
to be more protective of the Needs Review state.

I have been, from time to time, when I'm in commitfest management mode, 
aggressive in setting entries back to Waiting on Author, but that's not 
always optimal.

So a third status that encompasses the various other situations like 
maybe forgotten by author, disagreements between author and reviewer, 
process difficulties, needs some senior developer intervention, etc. 
could be helpful.

This could also help scale the commitfest manager role, because then the 
head CFM could have like three helpers and just tell them, look at all 
the "Unclear" ones and help resolve them.

view thread (21+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: commitfest.postgresql.org is no longer fit for purpose
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox