Content-Type: multipart/alternative;
 boundary="------------QyyztsSU405FBr4dEBzvJel6"
Message-ID: <b2be6254-c977-4329-b62f-c35ba8772641@postgrespro.ru>
Date: Tue, 4 Feb 2025 16:06:15 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC: track vacuum/analyze cumulative time per relation
To: Michael Paquier <michael@paquier.xyz>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Sami Imseih <samimseih@gmail.com>
References: <CAA5RZ0s8=wd-X4GgMcFQO1WbwPtw4HjTtMcDahsnegZ8p6tYPQ@mail.gmail.com>
 <Z4peXI1UtEl477DY@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA5RZ0vKWKULGZ_V8DOOtFHXtsOLMVLCpkJ+guniB66T-o_eZA@mail.gmail.com>
 <Z43CHdLQvUWwTSrM@paquier.xyz>
 <CAA5RZ0su2Unc+iJkhL6QEfsbjj6-WXjRWyf2E0b4BotUH=o4FA@mail.gmail.com>
 <Z5NCHYaTBML1Chfk@paquier.xyz>
 <CAA5RZ0s9FSC8cU65D_XeV19-Zd3kFgJrBokGjq-=_Ccpjk6ZLw@mail.gmail.com>
 <Z5bTmITFvGw_v6Ci@paquier.xyz>
 <Z5eKmuxH/x0+jWRV@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA5RZ0vpAA+jXiCjjO5DGbLTUVmqe99ioCx0dkg1FKNc1h2biA@mail.gmail.com>
 <Z5gsBj-mPVv3QCI1@paquier.xyz>
Content-Language: en-US
From: Alena Rybakina <a.rybakina@postgrespro.ru>
In-Reply-To: <Z5gsBj-mPVv3QCI1@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/b2be6254-c977-4329-b62f-c35ba8772641%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------QyyztsSU405FBr4dEBzvJel6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi!

On 28.01.2025 03:59, Michael Paquier wrote:
> On Mon, Jan 27, 2025 at 11:22:16AM -0600, Sami Imseih wrote:
>>> I have put my hands on this patch, and at the end I think that we
>>> should just do the attached, which is simpler and addresses your
>>> use-case.  Note also that the end time is acquired while the entries
>>> are not locked in the report routines, and some tweaks in the docs and
>>> comments.
>> Thanks for the update. This LGTM.
> Okidoki.  Done, then, with bumps for the catalog version and the stats
> file version.

You might be interested in looking at my patch for collecting vacuum 
statistics? Same issue, but it collects more information about the 
vacuum procedure for relations and databases.

I mentioned it here [0] in the current thread.

[0] 
https://www.postgresql.org/message-id/Z4U3hkWuEgByhGgJ%40ip-10-97-1-34.eu-west-3.compute.internal 


-- 
Regards,
Alena Rybakina
Postgres Professional

--------------QyyztsSU405FBr4dEBzvJel6
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hi!<br>
    </p>
    <div class="moz-cite-prefix">On 28.01.2025 03:59, Michael Paquier
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:Z5gsBj-mPVv3QCI1@paquier.xyz">
      <pre class="moz-quote-pre" wrap="">On Mon, Jan 27, 2025 at 11:22:16AM -0600, Sami Imseih wrote:
</pre>
      <blockquote type="cite">
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">I have put my hands on this patch, and at the end I think that we
should just do the attached, which is simpler and addresses your
use-case.  Note also that the end time is acquired while the entries
are not locked in the report routines, and some tweaks in the docs and
comments.
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">
Thanks for the update. This LGTM.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Okidoki.  Done, then, with bumps for the catalog version and the stats
file version.
</pre>
    </blockquote>
    <br>
    <p>You might be interested in looking at my patch for collecting
      vacuum statistics? Same issue, but it collects more information
      about the vacuum procedure for relations and databases.</p>
    <p><span style="white-space: pre-wrap">I mentioned it here [0] in the current thread.</span></p>
    <p><span style="white-space: pre-wrap">[0] <a class="moz-txt-link-freetext" href="https://www.postgresql.org/message-id/Z4U3hkWuEgByhGgJ%40ip-10-97-1-34.eu-west-3.compute.internal">https://www.postgresql.org/message-id/Z4U3hkWuEgByhGgJ%40ip-10-97-1-34.eu-west-3.compute.internal</a>
</span></p>
    <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional</pre>
  </body>
</html>

--------------QyyztsSU405FBr4dEBzvJel6--