Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nWg0j-0006D8-Pp
	for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Mar 2022 15:01:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nWg0i-0005Zq-MI
	for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Mar 2022 15:01:24 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <peter.eisentraut@enterprisedb.com>)
	id 1nWg0i-0005Zh-CV
	for pgsql-hackers@lists.postgresql.org; Tue, 22 Mar 2022 15:01:24 +0000
Received: from out5-smtp.messagingengine.com ([66.111.4.29])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <peter.eisentraut@enterprisedb.com>)
	id 1nWg0f-0007aS-Gk
	for pgsql-hackers@lists.postgresql.org; Tue, 22 Mar 2022 15:01:23 +0000
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
	by mailout.nyi.internal (Postfix) with ESMTP id 959565C01C9;
	Tue, 22 Mar 2022 11:01:20 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
  by compute3.internal (MEProxy); Tue, 22 Mar 2022 11:01:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm3; bh=k9Rs0JikWL9h9UAnSsaCNYpd/mg0wW5lrdi1s78KX
	wI=; b=WRB1JLkc1ccWGjSLA1XPgKQ5GkQ/mZCiQSTIBpKHGG/LTActR8dflYWGW
	1jzLFreOcj1FvX9j0Wt+WR7i8CgiJvH+WiWmmaZRldD6BmFubH7Wq08HKSv3sskj
	Kv0BHXlwsGGYJfyoRawgGNDgx9QQPD+0J+o5WDP/o+5gQr7592U7zN6rVRohbzVL
	n3JrH6RvSRL24xPG9YY0A8PIRxuztHbynCYIZ6ENLdl5kc8BAniT7Ox1GMuuxVLj
	xG8yqfTF2P1JdaCOYCYf8BO+JC0h2gpp/X1HFhnYk09RJcLb+xRNi5nxJgLnPAGe
	ciYK8TYty14mGEcvt9pwFO7xir5nw==
X-ME-Sender: <xms:vuQ5YjzO_fJehCmJipYqXWGwA1I0year9Ic03_bvA3OcQBkwtNfRYw>
    <xme:vuQ5YrTToOwZa4H2mFiTQpQes4_TOFBK9_-KewzVyrVMhefUx6PDWNo_1Y096-f6a
    Qqwn9WWN_Q5PI4i6Q>
X-ME-Received: <xmr:vuQ5YtUz_nc44lNNZnHPSmxdP9XmecrG--esNcHoHRDgEXmSlIvlZtIKm_RDNC96XhgbKl5h0I_ho3e6pxURRqYctpXrSA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeghedgieelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv
    rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg
    hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepfeejgeehteeuhfevvedu
    leeufedtjeetiefftedvudfhtdeifefgueettdevgefgnecuvehluhhsthgvrhfuihiivg
    eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht
    segvnhhtvghrphhrihhsvggusgdrtghomh
X-ME-Proxy: <xmx:v-Q5YtjbDD20ZoR898GvydflfYf69CHaJkxsQJ2tWNpia4X_st7HVA>
    <xmx:v-Q5YlBvYcPsjv7O3EjisEXdHGgMBpDJvKSUWbVx61UTDtruFcYgiA>
    <xmx:v-Q5YmLhJDl7q6vcT9HcQ_Nd9_kenA5kGBZD0cKjTH6eUfEtHdR9iA>
    <xmx:wOQ5Ypui8FQPHWPngaAaO3PiF6yCuDXlYJCu_-Hejk0_KwwEUix17w>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 22 Mar 2022 11:01:18 -0400 (EDT)
Message-ID: <b3b4a89f-9dd8-dcc3-d75d-118ec80ce471@enterprisedb.com>
Date: Tue, 22 Mar 2022 16:01:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: psql - add SHOW_ALL_RESULTS option
Content-Language: en-US
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com>
 <alpine.DEB.2.22.394.2107221655020.25741@pseudo>
 <6954328d-96f2-77f7-735f-7ce493a40949@enterprisedb.com>
 <alpine.DEB.2.22.394.2109251058000.3216312@pseudo>
 <alpine.DEB.2.22.394.2110021622530.2817726@pseudo>
 <2570e2ae-fa0f-aac9-f72f-bb59a9983a20@enterprisedb.com>
 <alpine.DEB.2.22.394.2112230703530.2668598@pseudo>
 <46259d13-5f90-1475-3c85-d7a597a2b862@enterprisedb.com>
 <alpine.DEB.2.22.394.2201040851220.3857182@pseudo>
 <alpine.DEB.2.22.394.2201081931170.731324@pseudo>
 <20220113054433.wdjhidtm7gvyhfts@alap3.anarazel.de>
 <alpine.DEB.2.22.394.2201150938470.3378943@pseudo>
 <805c0496-d60d-802b-3d61-73fed38dea16@enterprisedb.com>
 <alpine.DEB.2.22.394.2203041443080.538147@pseudo>
 <alpine.DEB.2.22.394.2203121726590.3679190@pseudo>
 <f54c68a7-a8ac-d538-ec7c-ee7e090fefd8@enterprisedb.com>
 <alpine.DEB.2.22.394.2203171859410.1198186@pseudo>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <alpine.DEB.2.22.394.2203171859410.1198186@pseudo>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/b3b4a89f-9dd8-dcc3-d75d-118ec80ce471%40enterprisedb.com>
Precedence: bulk

On 17.03.22 19:04, Fabien COELHO wrote:
> Indeed! The missing part was put back in v17.

Some unrelated notes on this v17 patch:

-use Test::More;
+use Test::More tests => 41;

The test counts are not needed/wanted anymore.


+
+\set ECHO none
+

This seems inappropriate.


+--
+-- autocommit
+--

+--
+-- test ON_ERROR_ROLLBACK
+--

This test file already contains tests for autocommit and 
ON_ERROR_ROLLBACK.  If you want to change those, please add yours into 
the existing sections, not make new ones.  I'm not sure if your tests 
add any new coverage, or if it is just duplicate.