Received: from localhost (unknown [200.46.204.183]) by developer.postgresql.org (Postfix) with ESMTP id AACD42E0054 for ; Tue, 20 May 2008 14:29:59 -0300 (ADT) Received: from developer.postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 39200-03 for ; Tue, 20 May 2008 14:29:55 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.153]) by developer.postgresql.org (Postfix) with ESMTP id B271B2E0032 for ; Tue, 20 May 2008 14:29:56 -0300 (ADT) Received: by fg-out-1718.google.com with SMTP id 16so2415877fgg.23 for ; Tue, 20 May 2008 10:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=J9iL0gSSM5v1c4HzxMyJhmKbLxoLhDv4EsNirtowb+0=; b=H3A+wv2SiGEPI0Xhs+Eun1tS9NYfjU6t4RUNKt34DlpFDS/YmaHtsQ5HMekS9nxJWdfsu+OBtnWUwBTMYdN5yUekdJmttkdWHGTtL8nxfsvkL3G8SR6YKRtg28jDs5RfFegLQcwgV9XrX3RbvQ+63CnOjNHSBonYQoHFljX3aLI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=YDTybug1eO+Kwj58xNefCX73kC7SZwX9iF/Mcrg+s1BJey2VFEExz7pCZvmEF5jxoDkr1JpcUnf2H2jvPbnpf6bDte2CNKnmpDbWangYvrVRHjhen+IxBwGD8QmBxTAxLKGZ0TXrOiPIJvl9l/N9/ptRQdYj5h6U4xaBZdu5SQc= Received: by 10.82.170.3 with SMTP id s3mr1259878bue.72.1211304595481; Tue, 20 May 2008 10:29:55 -0700 (PDT) Received: by 10.82.145.1 with HTTP; Tue, 20 May 2008 10:29:55 -0700 (PDT) Message-ID: Date: Tue, 20 May 2008 13:29:55 -0400 From: "Merlin Moncure" To: "Tom Lane" Subject: Re: libpq object hooks (libpq events) Cc: "Andrew Chernow" , "Andrew Dunstan" , "Alvaro Herrera" , "Patches (PostgreSQL)" In-Reply-To: <12200.1211242959@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <482A58D8.2030205@dunslane.net> <20080514043313.GS6966@alvh.no-ip.org> <482AD896.4000504@dunslane.net> <19342.1210776271@sss.pgh.pa.us> <482B1480.1070705@esilo.com> <482B2AC5.7000503@esilo.com> <482ECF62.7010901@esilo.com> <12200.1211242959@sss.pgh.pa.us> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200805/402 X-Sequence-Number: 6428 On Mon, May 19, 2008 at 8:22 PM, Tom Lane wrote: > Andrew Chernow writes: >> Here is an updated patch for what was called object hooks. This is now >> called libpq events. If someone has a better name or hates ours, let us >> know. > > This is starting to get there, Interesting you haven't commented on two areas, the actual placement of the event callers in the libpq code (i'm assuming these are ok), and the PQcopyResult/PQsetvalue functions. The latter area introduces some new behavior into standard libpq (imo) so it deserves some scrutiny. merlin