Message-ID: <b4a53c52-a983-499e-bde0-2d2c818751c5@iki.fi>
Date: Mon, 4 Nov 2024 18:08:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Latches vs lwlock contention
To: Maxim Orlov <orlovmg@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Yura Sokolov <y.sokolov@postgrespro.ru>, Andres Freund <andres@anarazel.de>
References: <CA+hUKGKmO7ze0Z6WXKdrLxmvYa=zVGGXOO30MMktufofVwEm1A@mail.gmail.com>
 <53c844e1-a21a-e481-cca5-2184c8aa47b9@iki.fi>
 <7c2090cd-a72a-4e34-afaa-6dd2ef31440e@iki.fi>
 <CACG=ezYS6sKbWa=Py23jH8P-SXGbZ+z6T_rYaEwfjGfh_yLgrQ@mail.gmail.com>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <CACG=ezYS6sKbWa=Py23jH8P-SXGbZ+z6T_rYaEwfjGfh_yLgrQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/b4a53c52-a983-499e-bde0-2d2c818751c5%40iki.fi>
Precedence: bulk

On 10/09/2024 19:53, Maxim Orlov wrote:
> I looked at the patch set and found it quite useful.
> 
> The first 7 patches are just refactoring and may be committed separately 
> if needed.
> There were minor problems: patch #5 don't want to apply clearly and the 
> #8 is complained
> about partitionLock is unused if we build without asserts. So, I add a 
> PG_USED_FOR_ASSERTS_ONLY
> to solve the last issue.
> 
> Again, overall patch looks good and seems useful to me. Here is the 
> rebased v5 version based on Heikki's patch set above.

Committed, thanks for the review!

In case you're wondering, I committed some of the smaller patches 
separately, but also squashed some of them with the main patch,  On 
closer look, the first patch, "Remove LOCK_PRINT() call that could point 
to garbage", wasn't fixing any existing issue. The LOCK_PRINT() was 
fine, because we held the partition lock. But it became necessary with 
the main patch, so I squashed it with that. And the others that I 
squashed were just not that interesting on their own.

The rest of Thomas's SetLatches work remains, so I left the commitfest 
entry in "Needs review" state.

-- 
Heikki Linnakangas
Neon (https://neon.tech)