Message-ID: <b4ad535a72fc02ea43076cf525e4dbaa72b00d5b.camel@j-davis.com>
Subject: Re: Checkpointer write combining
From: Jeff Davis <pgsql@j-davis.com>
To: Melanie Plageman <melanieplageman@gmail.com>, Nazir Bilal Yavuz
	 <byavuz81@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund
	 <andres@anarazel.de>
Date: Tue, 09 Sep 2025 18:28:55 -0700
In-Reply-To: 
 <CAAKRu_bz=t1FGXhUytPx9SC648-ozb-UxBps4zWUmS2XMg4Z4A@mail.gmail.com>
References: 
	<CAAKRu_bcWRvRwZUop_d9vzF9nHAiT+-uPzkJ=S3ShZ1GqeAYOw@mail.gmail.com>
	 <CAAKRu_bQWv5hJH0ncbGw8BEufAxdwMw4KY0KYuYLaw6KA=fpCA@mail.gmail.com>
	 <CAN55FZ3FOv+ubp4yyFKt=Rr+ceM0tfXRDVr6nKgqSyWXh8G8Gg@mail.gmail.com>
	 <CAAKRu_Yurj0sabXZB5EVqO3fKgwN1vELe1H4e0s1zXV3MKbZjQ@mail.gmail.com>
	 <CAAKRu_bv2=_DU-tYFdTQJj7ohKUyFnrJvETyCes3_NpFzvVt4Q@mail.gmail.com>
	 <CAAKRu_bz=t1FGXhUytPx9SC648-ozb-UxBps4zWUmS2XMg4Z4A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/b4ad535a72fc02ea43076cf525e4dbaa72b00d5b.camel%40j-davis.com>
Precedence: bulk

On Tue, 2025-09-09 at 13:55 -0400, Melanie Plageman wrote:
> On Tue, Sep 9, 2025 at 11:16=E2=80=AFAM Melanie Plageman
> <melanieplageman@gmail.com> wrote:
> >=20
> > One more fix and a bit more cleanup in attached v4.
>=20
> Okay one more version: I updated the thread on eager flushing the
> bulkwrite ring [1], and some updates were needed here.

v5-0005 comments:

  * Please update the comment above the code change.
  * The last paragraph in the commit message has a typo: "potentially
update the local copy of min recovery point, when xlog inserts are
*not* allowed", right?
  * Shouldn't the code be consistent between XLogNeedsFlush() and
XLogFlush()? The latter only checks for !XLogInsertAllowed(), whereas
the former also checks for RecoveryInProgress().

I'm still not sure I understand the problem situation this is fixing,
but that's being discussed in another thread.

Regards,
	Jeff Davis