Content-Type: multipart/mixed; boundary="------------VFW1MEAj20nQLB1F9tCfoNlF"
Message-ID: <b4e468d8-0cd6-42e6-ac8a-1d6afa6e0cf1@proxel.se>
Date: Tue, 29 Oct 2024 19:50:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Andreas Karlsson <andreas@proxel.se>
Subject: Always have pg_dump write rules in a consistent order
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/b4e468d8-0cd6-42e6-ac8a-1d6afa6e0cf1%40proxel.se>
Precedence: bulk

This is a multi-part message in MIME format.
--------------VFW1MEAj20nQLB1F9tCfoNlF
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

When working on a new feature for PostgreSQL I noticed that the 
pg_upgrade tests became flaky due to rules being dumped in a different 
order between the original cluster and the upgraded cluster. (For 
context: my regress scripts left a bunch of views with dependency 
circles which I had forgot to clean up.)

So I propose that we sort rules on (schema, name, relation_name) instead 
of (schema, name, oid) like it currently does. The patch itself is small 
enough and makes it easier to test that we upgrade rules and views 
correctly with pg_upgrade.

Andreas

--------------VFW1MEAj20nQLB1F9tCfoNlF
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Make-pg_dump-always-write-rules-in-a-stable-order.patch"
Content-Disposition: attachment;
 filename*0="0001-Make-pg_dump-always-write-rules-in-a-stable-order.patch"
Content-Transfer-Encoding: base64

RnJvbSAxOGIzOWYwZTc5MzA2MDgyNDgxYzdlZTMwNGRlNTc4ZjViMzJhNmI3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZWFzIEthcmxzc29uIDxhbmRyZWFzQHByb3hl
bC5zZT4KRGF0ZTogVHVlLCAyOSBPY3QgMjAyNCAxNDo1OTowNCArMDEwMApTdWJqZWN0OiBb
UEFUQ0hdIE1ha2UgcGdfZHVtcCBhbHdheXMgd3JpdGUgcnVsZXMgaW4gYSBzdGFibGUgb3Jk
ZXIKCkluc3RlYWQgb2Ygc29ydGluZyBydWxlcyBieSBzY2hlbWEgYW5kIG5hbWUgYW5kIHRo
ZW4gZmluYWxseSBvaWQgaW4KcGdfZHVtcCB3ZSBzb3J0IHRoZW0gYnkgc2NoZW1hLCBuYW1l
IGFuZCByZWxhdGlvbiBuYW1lLiBUaGlzIHdheSB3ZSBtYWtlCnN1cmUgdGhhdCB0aGUgb3Jk
ZXIgcnVsZXMgYXJlIGR1bXBlZCBpbiBjb25zaXN0ZW50IGFjcm9zcyBkdW1wIHBsdXMKcmVz
dG9yZS4KClRoaXMgaXMgZXNwZWNpYWxseSBhIGJpZyBwcm9ibGVtIGlmIHdlIGhhdmUgdG8g
YnJlYWsgZGVwZWRuZW5jeSBtYW55CmN5Y2xlcyBpbnZvbHZpbmcgdmlld3MgYW5kIHdlIGdl
dCBhIGxvdCBvZiB2aWV3cyBuYW1lZCBfUkVUVVJOLgotLS0KIHNyYy9iaW4vcGdfZHVtcC9w
Z19kdW1wX3NvcnQuYyB8IDExICsrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5z
ZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9wZ19kdW1wX3NvcnQu
YyBiL3NyYy9iaW4vcGdfZHVtcC9wZ19kdW1wX3NvcnQuYwppbmRleCA0Y2I3NTRjYWE1NS4u
ZTBmNzBhYmRjYzIgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVtcC9wZ19kdW1wX3NvcnQu
YworKysgYi9zcmMvYmluL3BnX2R1bXAvcGdfZHVtcF9zb3J0LmMKQEAgLTMwNSw2ICszMDUs
MTcgQEAgRE9UeXBlTmFtZUNvbXBhcmUoY29uc3Qgdm9pZCAqcDEsIGNvbnN0IHZvaWQgKnAy
KQogCQlpZiAoY21wdmFsICE9IDApCiAJCQlyZXR1cm4gY21wdmFsOwogCX0KKwllbHNlIGlm
IChvYmoxLT5vYmpUeXBlID09IERPX1JVTEUpCisJeworCQlSdWxlSW5mbyAqcm9iajEgPSAq
KFJ1bGVJbmZvICpjb25zdCAqKSBwMTsKKwkJUnVsZUluZm8gKnJvYmoyID0gKihSdWxlSW5m
byAqY29uc3QgKikgcDI7CisKKwkJLyogU29ydCBieSB0aGUgcnVsZSdzIHRhYmxlIG5hbWUg
KG5hbWVzcGFjZSBhbmQgbmFtZSB3ZXJlIGNvbnNpZGVyZWQgYWxyZWFkeSkgKi8KKwkJY21w
dmFsID0gc3RyY21wKHJvYmoxLT5ydWxldGFibGUtPmRvYmoubmFtZSwKKwkJCQkJCXJvYmoy
LT5ydWxldGFibGUtPmRvYmoubmFtZSk7CisJCWlmIChjbXB2YWwgIT0gMCkKKwkJCXJldHVy
biBjbXB2YWw7CisJfQogCiAJLyogVXN1YWxseSBzaG91bGRuJ3QgZ2V0IGhlcmUsIGJ1dCBp
ZiB3ZSBkbywgc29ydCBieSBPSUQgKi8KIAlyZXR1cm4gb2lkY21wKG9iajEtPmNhdElkLm9p
ZCwgb2JqMi0+Y2F0SWQub2lkKTsKLS0gCjIuNDUuMgoK

--------------VFW1MEAj20nQLB1F9tCfoNlF--