Message-ID: <b5951fd8a69d00464e517886d6dc0b65b12bcdb6.camel@gmail.com>
Subject: Re: splitting pg_resetwal output strings
From: "Jonathan Gonzalez V." <jonathan.abdiel@gmail.com>
To: =?ISO-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>, Pg Hackers
	 <pgsql-hackers@lists.postgresql.org>
In-Reply-To: <202601311502.ohp4cx7hfms2@alvherre.pgsql>
References: <202601311502.ohp4cx7hfms2@alvherre.pgsql>
Autocrypt: addr=jonathan.abdiel@gmail.com; prefer-encrypt=mutual;
 keydata=mQINBF1Rbm8BEADc2lW3toboDjMLry1spo/hxUiMKlA+CDCMwXPZPvyB4TGCQAVYnU+gS
 NgBJ8H7CF8ghllm9OYeqdRoRvr1unQN5RUShUWTsLhznUu5KV0KfhFbEjQyH7lDeVCzMRNr5r27QT
 RrmycqAacistMqtjfnsG/j8+HQU9tLrOdnhsxIRUZN/guHBEwx3LVp77lf9HMWabnSgGQVOqhUzA6
 P97j8oWRwQNDZjHFVf5k4HMHJRp8OzcvXUOSa+ynH33xBsrLPDza0X6y7pZlfYbmjXdwU/XKSd7oB
 4BeChFbrmdilIeSAGKLAHURH9jKeRxDt9pzYMvsIiK9UZlThnEgAVM2IqQzhnzd4jxG13Hi8HZ82O
 2Ng4n36kVh5uz0NoIGJ6Guw9R+gqHHxbeSdt8S0P+2VO80UTX+hF7OPbLjE7w8wsTt37Ekp+jRxUs
 RooShDvnUENiw+TkyPszUZ0k9BZmfwcaC3++WDYyWvGK20wty3ZZMjl69SDdQXQaRu8E59leIpKw6
 p8HBBAGZgytVPUN61w52r9dgX9RW0ujBrEztRNWPaDauedKGCXrL678mq7KwYW6Rg+y9orvZJPLUq
 Z7/m8RJUaeuJdz2LJ2bioUJ2BaPX7YxXdqMm9LZWknzy/pyF8iZHXD5D3H+WNJROlcQ6TQNLqUB11
 KRK0koNeqiNbwARAQABtDlKb25hdGhhbiBHb256YWxleiBWLiA8am9uYXRoYW4uZ29uemFsZXpAZW
 50ZXJwcmlzZWRiLmNvbT6JAlQEEwEKAD4CGwMCHgECF4AFCwkIBwMFFQoJCAsFFgIDAQAWIQQSbD6
 5ytnQRUDy/MNDze8Kc6UcxQUCaY2PJAUJDh1UNQAKCRBDze8Kc6UcxXl0D/9GitE44UsOyJKtRR/Q
 T45vrSkg+OsHFQQTTJmAZf+jzeMMvW9PDHnG9aX+JEM8vDl6EL6X3Q2sf7/Yi4XX7FneiNNpBJGml
 Ak7DsNQRwP6wnD5AOteDztBFm5QMJTqoVOqQn3/WtFUuJfPEd9fNaUh8DUhXXScKEqSqBSr+bZE1/
 fVF/i5nCSwlOTXVIPaVGB2Q92eGfXQnwSK2pxV5+VBP6oiW3bTf1HwD+NpKEAWDJ2utc4OAXmLuGU
 ZdiaxuUwud0xTgHxBPoei2C9SsuJ7VjlqYXUN2EgFdAysH3Gx9hHVEDE/dG2kq6K72hG2ze5Zzp2u
 Xg3QZVcTN90WWTblhFyB/dGm5iBCClPHqyhSCFdYrclEY/4kPafl3WLiKkRZyb2GZ96uLu8LYt9/F
 sLsc3HR3i3rGQ0XIdiUcbaSG4OE7rJDGV+hTfu7xxPzy1Wc4bclqmdya5g4I0u5saM9NBEYpPc5E9
 Bb/w8F+QQZ6XVITGUxgdr0K3anflleAANqtNGpW5pQE5ukRKpqcl1YK8PkuxdHf/RjbB3RSx3h6qw
 NTQqlZWmzk6fotgFfgD1EK8brCIRYMJutWvAiDQ+AWrfGdEGx0ZrbjEqR/67DTNJXMEOIDPc/eVvD
 qe5F7IvxrFu06EEC6E97K6aTHfm339RlE4+DpqLrjnls/vIJ/LQwSm9uYXRoYW4gR29uemFsZXogV
 i4gPGpvbmF0aGFuLmFiZGllbEBnbWFpbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUKCQ
 gLBRYCAwEAFiEEEmw+ucrZ0EVA8vzDQ83vCnOlHMUFAmmNjyUFCQ4dVDUACgkQQ83vCnOlHMVwJQ/
 9GAxjP7q/ZU/ZmZ1kBdeAzsL0AZLGkXnkDCdIrXS9NB1gR63bjLzIFvyAKpofRuJkKex1ZorDeXmd
 DrIXCcZTRFSxq13X81z4QANFWMe/a7MTG0f7b0t7FTfmjq4QeC8zcbuj3zS4dvBMGH2QdOSrttnnz
 ogTAnVK0tg8dF+8mWQ6fHoepch0Zlcbb1nnMGdcEdq6D9kwpYQWhD64dFmou+NrG8cFAbskmEqSbu
 FjmQIjPY9yhYhMtJzB32eCkcSXrpEQiEDhy/2YVyzQ/xPnSLgPa1n6J04DbsO38GFADhT6oJowunj
 8WGbN7e1XJr2qAo/pnmqdfn4eEXIPSgfQhIRT4Z/JwR/IljYHD5HJZUA5DTU1zDTEjuOe8YCFkIoi
 QPM07QHeMTP4oyqAEoxv/CTJNDMRt7hx8zvo5OmAg8BmUDX46kwkRlAfNVM01BFnYHiREuW/8mF9H
 fQH8sEiKOfkq0ZyHtuuQ4HXh6MyrfPP2mUzcphG87/bl/rEQIDLqseBqVEc+sfg9zoLezqM7EmfG0
 9dnDH9d1JwhM9UW5TPl7yJq1Zd7nv6DdLog/Cdgdqu6ZroTrv2Vp+jdgmimgZYaWnB2iaj6fNz/w+
 HsitfS+7V+yRUou3+hH5JNkWpGibVosOeYgK8PHMRzqNRl9m859rcrXM/iWYqUFacVXm0N0pvbmF0
 aGFuIEdvbnphbGV6IFYgPGpvbmF0aGFuLmdvbnphbGV6QDJuZHF1YWRyYW50LmNvbT6JAlQEEwEKA
 D4CGwMCHgECF4AFCwkIBwMFFQoJCAsFFgIDAQAWIQQSbD65ytnQRUDy/MNDze8Kc6UcxQUCaY2PJQ
 UJDh1UNQAKCRBDze8Kc6UcxeQaEADHYERzaodpec8m2ZNF04gj9Ra3udvurrpab4598TeKwNsODvZ
 ASMY0fjATtnduEirypa0mS3jMK51XVFz7WUxqm/zccWGCivzn4+Zl8yqhn0Exf57ORACQeB5UJ0UU
 Fl/8Z1LxEe0uS0XiUnS8tfpS/LxP0PkT+gNIS0Tqo1IMZD30ANt4wfrrnR8Bzy2E6/5J0vNtKhpNm
 bdwAT5lwaM0bc+o6IKIaSTpoEdaF1XnW8ThOs2nxhmIQmaFNM48GqeKny65shxYDmn58e093v5T2U
 1QrUUhFt6sAapbSLvekNWBCNlqE6dwDcuYSA53Shn/bX4kLoMX4yk6pfCIr9j+wLShq0mVRznBM+J
 WTF5NtUoD4NvYTXdOfdsnbfDdUFRQDqsDOpl8gsQW3N5Rc54jAAd+W6bgP05GeoiwM+SmedNlJiSQ
 NnMw0vtV8u2B2AVgCD8UvOZP3mLUiTmHymD2HmXIXhOn+O7l5fymNMrCYv5ihAMsA20RExVfZ+I37
 Qt+uJcsPSf7lvcWSJkoB0oktwnq9UUxYF0FNyFfaPGfCKxRvBeVD8qcZpOTWh9pTy0urM31MIaZPh
 MkBrl4WZ2pXqzkkqGn6daY9g5/4oPgazAmqRSfxdDmAbG08STMMvqimaIc2DHYZTRjNKBDvO7Xmef
 plnv3mXrjZZoDBMglnQ==
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="=-VBrWlC9Qpvr+AJpkaoZ/"
Date: Sat, 23 May 2026 17:31:57 +0200
MIME-Version: 1.0
User-Agent: Evolution 3.56.2-9 
Archived-At: 
 <https://www.postgresql.org/message-id/b5951fd8a69d00464e517886d6dc0b65b12bcdb6.camel%40gmail.com>
Precedence: bulk


--=-VBrWlC9Qpvr+AJpkaoZ/
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable

Hello!

I've tested the patch, and I found that in the first patch, the nsl.mk
file is changed to match the first argument of CONTROLDATA_LINE as the
string to match:

+GETTEXT_TRIGGERS =3D $(FRONTEND_COMMON_GETTEXT_TRIGGERS) \
+				  CONTROLDATA_LINE:1

but in the second patch the CONTROLDATA_LINE moves the strings to the
second argument:

-CONTROLDATA_LINE("pg_control version number",
+CONTROLDATA_LINE(CD_CONTROL_VERSION, "pg_control version number",
 				"%u", ControlFile.pg_control_version)

While keeping the argument as it is, I suggest to switch to
CONTROLDATA_LINE:2 like this:

+GETTEXT_TRIGGERS =3D $(FRONTEND_COMMON_GETTEXT_TRIGGERS) \
+				  CONTROLDATA_LINE:2

This will make `make update-po` take the strings from entries.h, which
is what I was expecting.

During testing, I found a couple of things that may be interesting, or
at least worth keeping in mind for the future implementation already
mentioned [1].

Even if the spacing calculation is correct, I found that the font size
is not the same for different languages, so if a strings or part of it,
is translated into, for example, Hindi, and most of it it's in English,
it will affect how it look in the terminal, meaning that it's probably
that a the second column will be moved to the left generating a
misalignment in the printed data

Regards!

[1]
https://www.postgresql.org/message-id/202509300530.jnwbfyrdxaah%40alvherre.=
pgsql
[2] https://sw.kovidgoyal.net/kitty/

--=20
Jonathan Gonzalez V.=20
EDB: https://www.enterprisedb.com

--=-VBrWlC9Qpvr+AJpkaoZ/
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEEmw+ucrZ0EVA8vzDQ83vCnOlHMUFAmoRyGwACgkQQ83vCnOl
HMXVXg/6Atj6sfsr5ZcRImsFQ9JYvjlginElSq7FahSl9B9eBwWMmgRLL38wgTuY
fYRmJtRT5/LhhjNqqGg2m51tw9dNThNbPa2l8ysDxCiOJlRN5OGTPv4ZHcO/Wjvs
gnD4FB56X/vHuuZZHRBfbdV14jr355yu75tWwoywE1hoyrrEOyDsYuQGijhYRu62
xdMeOIfhoSxSQ/nOJexnVLwVYC2nXLZ+CuU/0X0cqdAO9Z1kriu+o3lPRbadIgd5
SPBD8JcicoB29KU+TQyTOWdR/H69DoK0bmitLtuQ1QINEJEutLybjVUPMlhkRRPJ
Inn8tGjRge2JI5kOJGPTi94n+9NoCEdDNErfAW1ItFgKs5R4k0HeBSu4D15OLlGX
MTV/Kv6SGojJ6jZ7opGn7ii4Vmr1mVVtgZgAmOD18zyl+NQF6Py6GnRQoDED52Gq
iEhp1Y/yC/mULEzDs4bcKwV0NdVf9pHxyJsjCw5qbVXxGt7WX1c/1umXz5i2tMvD
xM8IGYxxr1hMJ26x/I02GOJlIZRoM9GaJ3kOccgcyWpKQm34uCVBTi74SyXlQoUS
zgjXVbjE1kqNQm/+ZwkXyhBoQoJ5T0Ko9hG5Q/LQimiInSmMlkwJUBsvil9R5HQa
24NDkWQIOErejeID5TSgGxRJIRo8o7/BU6uXDZL4LSNbcDrd8V8=
=ab3o
-----END PGP SIGNATURE-----

--=-VBrWlC9Qpvr+AJpkaoZ/--