Message-ID: <b612b9cd-b59e-43d1-bb8a-e100c5ab9849@gmail.com>
Date: Tue, 13 Aug 2024 13:12:30 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Restart pg_usleep when interrupted
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
 Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Tom Lane
 <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <ZrowomFX5yMV9zUm@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZrpnfTVK-iaIW98I@nathan> <e3297b5e-0b33-4f45-afcd-4b00ba0b3547@gmail.com>
 <cb18c6a7-4394-4488-ad71-0b9826c8899c@iki.fi> <ZrqG0tIgP2HbGRm1@nathan>
 <2b5ac681-11d5-470d-af40-89ead9a868aa@gmail.com> <Zrt3ReA-nB7MJn2q@nathan>
 <90ec1618-58db-46b3-8c9b-13616ac839a7@gmail.com> <ZruCZOKzS0LGAGTb@nathan>
 <ac329991-7cfa-4006-b155-97ba19c5705d@gmail.com> <ZruMe-ppopQX4uP8@nathan>
Content-Language: en-US
From: "Imseih (AWS), Sami" <samimseih@gmail.com>
In-Reply-To: <ZruMe-ppopQX4uP8@nathan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/b612b9cd-b59e-43d1-bb8a-e100c5ab9849%40gmail.com>
Precedence: bulk

> None of this seems intractable to me.  1 Hz seems like an entirely
> reasonable place to start, and it is very easy to change (or to even make
> configurable).  pg_stat_progress_vacuum might show slightly old values in
> this column, but that should be easy enough to explain in the docs if we
> are really concerned about it.  If other callers want to do something
> similar, maybe we should add a more generic implementation in
> backend_progress.c.
>
I don't know if I agree. Making vacuum sleep more robust to handle
interrupts seems like a cleaner general solution than to add
even more code to handle this case or have to explain the behavior of
cost delay instrumentation in docs.


Regards,


Sami