MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 14 Aug 2023 12:31:05 +0900
From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Bharath Rupireddy
 <bharath.rupireddyforpostgres@gmail.com>, Tristan Partin
 <tristan@neon.tech>, pgsql-hackers@lists.postgresql.org
Subject: Re: Support to define custom wait events for extensions
In-Reply-To: <ZNlh9aeJe5KSJBNt@paquier.xyz>
References: <20230801032349.aaiuvhtrcvvcwzcx@awork3.anarazel.de>
 <9cc4136f9e3629a2ffc8ac66b4de3f31@oss.nttdata.com>
 <ZNGEImKhwtgL2zlq@paquier.xyz>
 <20230808225954.vh6xwikz4fxjbprz@awork3.anarazel.de>
 <ZNLJwViP14/4zcBx@paquier.xyz>
 <20230809003710.qhys7nvwhdujd4pm@awork3.anarazel.de>
 <0850ea2f23217b3a87340dd2d721d051@oss.nttdata.com>
 <ZNQlJ8pQIIWjv/he@paquier.xyz>
 <53dc58793eb3df17d2da8c2fc2275fac@oss.nttdata.com>
 <ZNSh41m/w9NERlnC@paquier.xyz> <ZNlh9aeJe5KSJBNt@paquier.xyz>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <b65a0ce07dd2c8a4f0edad04bf613d3b@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/b65a0ce07dd2c8a4f0edad04bf613d3b%40oss.nttdata.com>
Precedence: bulk

On 2023-08-14 08:06, Michael Paquier wrote:
> On Thu, Aug 10, 2023 at 05:37:55PM +0900, Michael Paquier wrote:
>> This looks correct, but perhaps we need to think harder about the
>> custom event names and define a convention when more of this stuff is
>> added to the core modules.
> 
> Okay, I have put my hands on that, fixing a couple of typos, polishing
> a couple of comments, clarifying the docs and applying an indentation.
> And here is a v4.
> 
> Any thoughts or comments?  I'd like to apply that soon, so as we are
> able to move on with the wait event catalog and assigning custom wait
> events to the other in-core modules.

Thanks! I confirmed the changes, and all tests passed.

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION