Feedback-ID: i131946ab:Fastmail
Message-ID: <b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com>
Date: Thu, 26 May 2022 16:36:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: pg_upgrade test writes to source directory
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <f80ace33-11fb-1cd3-20f8-98f51d151088@enterprisedb.com>
 <Yo3Z5JzHXn7sIe9N@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <Yo3Z5JzHXn7sIe9N@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b68a2c98-8690-c057-c9e1-79bc6db608a0%40enterprisedb.com>
Precedence: bulk

On 25.05.22 09:25, Michael Paquier wrote:
>> It looks like an addition of
>>
>>      chdir $ENV{TESTOUTDIR};
>>
>> could fix it.  Please check the patch.
> I think that you mean TESTDIR, and not TESTOUTDIR?

I chose TESTOUTDIR because it corresponds to the tmp_check directory, so 
that the output files of the pg_upgrade run are removed when the test 
artifacts are cleaned up.  When using TESTDIR, the pg_upgrade output 
files end up in the build directory, which is less bad than the source 
directory, but still not ideal.