Feedback-ID: i131946ab:Fastmail
Message-ID: <b6bca173-139f-1cc6-5aad-a1224a83c55b@enterprisedb.com>
Date: Wed, 22 Jun 2022 12:22:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: Add header support to text format and matching feature
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Verite <daniel@manitou-mail.org>,
 Julien Rouhaud <rjuju123@gmail.com>, Andrew Dunstan <andrew@dunslane.net>,
 Greg Stark <stark@mit.edu>, =?UTF-8?Q?R=c3=a9mi_Lapeyre?=
 <remi.lapeyre@lenstra.fr>, Zhihong Yu <zyu@yugabyte.com>,
 David Steele <david@pgmasters.net>, vignesh C <vignesh21@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <7ef90152-32e2-4f4b-9010-329a8dcc0c95@manitou-mail.org>
 <182b63dd-efa6-a108-4c28-fd5104518d01@enterprisedb.com>
 <Yq+5S+kZwSZVDAKG@paquier.xyz> <YrJViurLY8DHIjVA@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <YrJViurLY8DHIjVA@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b6bca173-139f-1cc6-5aad-a1224a83c55b%40enterprisedb.com>
Precedence: bulk


On 22.06.22 01:34, Michael Paquier wrote:
> On Mon, Jun 20, 2022 at 09:03:23AM +0900, Michael Paquier wrote:
>> On Thu, Jun 16, 2022 at 09:24:56AM +0200, Peter Eisentraut wrote:
>>> I don't feel very strongly about this.  It makes sense to stay consistent
>>> with the existing COPY code.
>>
>> Yes, my previous argument is based on consistency with the
>> surroundings.  I am not saying that this could not be made better, it
>> surely can, but I would recommend to tackle that in a separate patch,
>> and apply that to more areas than this specific one.
> 
> Peter, beta2 is planned for next week.  Do you think that you would be
> able to address this open item by the end of this week?  If not, and I
> have already looked at the proposed patch, I can jump in and help.

The latest patch was posted by you, so I was deferring to you to commit 
it.  Would you like me to do it?