To: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
From: Ian Barwick <ian.barwick@2ndquadrant.com>
Subject: doc: minor update for description of "pg_roles" view
Message-ID: <b6ec6167-5dd5-6347-ac1d-1fd49382019f@2ndquadrant.com>
Date: Wed, 10 Jul 2019 14:35:56 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------A6AA3FE843C677700D847284"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------A6AA3FE843C677700D847284
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi

Here:

   https://www.postgresql.org/docs/12/view-pg-roles.html

we state:

   "This view explicitly exposes the OID column of the underlying table,
    since that is needed to do joins to other catalogs."

I think it's superfluous to mention this now OIDs are exposed by default;
attached patch (for REL_12_STABLE and HEAD) simply removes this sentence.


Regards

Ian Barwick


-- 
  Ian Barwick                   https://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

--------------A6AA3FE843C677700D847284
Content-Type: text/x-patch;
 name="view-pg_roles.v1.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="view-pg_roles.v1.patch"

diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
new file mode 100644
index 3428a7c..68ad507
*** a/doc/src/sgml/catalogs.sgml
--- b/doc/src/sgml/catalogs.sgml
*************** SELECT * FROM pg_locks pl LEFT JOIN pg_p
*** 9995,10005 ****
     that blanks out the password field.
    </para>
  
-   <para>
-    This view explicitly exposes the OID column of the underlying table,
-    since that is needed to do joins to other catalogs.
-   </para>
- 
    <table>
     <title><structname>pg_roles</structname> Columns</title>
  
--- 9995,10000 ----

--------------A6AA3FE843C677700D847284--