Subject: Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Steele <david@pgmasters.net>, Stephen Frost <sfrost@snowman.net>,
 Michael Paquier <michael.paquier@gmail.com>,
 Haribabu Kommi <kommi.haribabu@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <16db4468-edfa-830a-f921-39a50498e77e@2ndquadrant.com>
 <19990.1500936945@sss.pgh.pa.us>
 <3d250597-384e-c5f4-7533-b513e366888f@2ndquadrant.com>
 <CAJrrPGeQcsBXhuJA1vQ25PS0wAqfo0v_mXtwmt4VcOmxKSvfCA@mail.gmail.com>
 <94f58897-861b-accf-a9f1-af4be816c0d3@2ndquadrant.com>
 <CAJrrPGfTQ3w=5BdprWgQghuM7ujtBy2Sthr6zRwY0QeRBQd2RQ@mail.gmail.com>
 <13097.1509650125@sss.pgh.pa.us>
 <3dca6a76-fa4b-66ab-c0db-496335d650b1@2ndquadrant.com>
 <CAB7nPqS4VSUiaFnGmR2k95-RtEi++SEwZk32pMu_31VLyMpK0Q@mail.gmail.com>
 <20180105042528.GK2416@tamriel.snowman.net>
 <1e831867-c46c-8f21-79d4-5de70cac5822@2ndquadrant.com>
 <13711.1515440364@sss.pgh.pa.us>
 <01387f5d-a95b-d159-becb-cf9ff9ba4e41@2ndquadrant.com>
 <db11d513-4af4-0d1b-514b-16617385f068@pgmasters.net>
 <8b29edcb-cbc0-5414-996f-520f75b94d3b@2ndquadrant.com>
 <3b3d8eac-c709-0d25-088e-b98339a1b28a@2ndquadrant.com>
 <14503.1521739732@sss.pgh.pa.us> <17044.1521748285@sss.pgh.pa.us>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Message-ID: <b6ef4913-f7ec-93ad-e774-49c7be04d963@2ndquadrant.com>
Date: Thu, 22 Mar 2018 21:15:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <17044.1521748285@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/22/2018 08:51 PM, Tom Lane wrote:
> I wrote:
>> Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>>> The 0002 part is the main part, unifying the definition of reltuples on
>>> three main places:
> 
>> On to this part ...
> 
> I've pushed 0002 with several corrections: it did not seem to me that
> you'd correctly propagated what ANALYZE is doing into CREATE INDEX or
> pgstattuple.  Also, since one of the things VACUUM does with num_tuples
> is to report it as "the total number of non-removable tuples", I thought
> we'd better leave that calculation alone.  I made the added code count
> live tuples in a new variable live_tuples, instead.
> 

OK, makes sense. Thanks.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services