Subject: Re: Improve logging when using Huge Pages
To: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 "rjuju123@gmail.com" <rjuju123@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
References: 
 <CAOBaU_YGfFyruW4YX6++DifTtBt8bjatz0gMhaTRD=dqV3gdWg@mail.gmail.com>
 <7e5b9f6d-1db9-d1e2-3bd8-ef65f24b35be@oss.nttdata.com>
 <TU4PR8401MB1152CB4FEB99658BC6B35543EECF9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
 <20210903.164934.1726669051525427478.horikyota.ntt@gmail.com>
 <1946f6b9-75a1-7aeb-7b06-6c018377e518@oss.nttdata.com>
 <2498302.1630679233@sss.pgh.pa.us>
 <f5d8ab35-a44d-2f28-b86f-cd939c1000c4@oss.nttdata.com>
 <TU4PR8401MB115257079749D8958A3450F7EED39@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <b707355a-84ba-9f8b-6026-8fac36121279@oss.nttdata.com>
Date: Tue, 7 Sep 2021 19:12:36 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: 
 <TU4PR8401MB115257079749D8958A3450F7EED39@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b707355a-84ba-9f8b-6026-8fac36121279%40oss.nttdata.com>
Precedence: bulk


On 2021/09/07 13:09, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
> Hello,
> 
> Thank you everyone for comments.
> In the thread [1] that Horiguchi told me about, there is already a review going on about GUC for HugePages memory.
> For this reason, I have removed the new GUC implementation and attached a patch that changes only the message at instance startup.

Thanks for updating the patch!

Even with the patch, there are still some cases where huge pages is
disabled silently. We should report something even in these cases?
For example, in the platform where huge pages is not supported,
it's silently disabled when huge_pages=try.

One big concern about the patch is that log message is always reported
when shared memory fails to be allocated with huge pages enabled
when huge_pages=try. Since huge_pages=try is the default setting,
many users would see this new log message whenever they start
the server. Those who don't need huge pages but just use the default
setting might think that such log messages would be noisy.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION