Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
To: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Amit Kapila <amit.kapila16@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <30823.1565030571@sss.pgh.pa.us>
 <CA+TgmobRpgiqCZ_FMUeDW4RM1W+RzT4HA2xSQy=QMcfv=X47jw@mail.gmail.com>
 <32103.1565032053@sss.pgh.pa.us> <20190806005225.GM29202@tamriel.snowman.net>
 <6cba0dff-485b-6781-d659-0a376b966c89@2ndquadrant.com>
 <20190806021616.GP29202@tamriel.snowman.net>
 <54620b18-60b7-4b9b-7d1d-90a6464ab333@2ndquadrant.com>
 <5879.1565121423@sss.pgh.pa.us> <20190806214355.GA29202@tamriel.snowman.net>
 <29770.1565810142@sss.pgh.pa.us> <20190814211520.GK16436@tamriel.snowman.net>
 <28723.1565882573@sss.pgh.pa.us>
From: Ian Barwick <ian.barwick@2ndquadrant.com>
Message-ID: <b71f742e-173a-8d83-7fc9-3b415f64269b@2ndquadrant.com>
Date: Wed, 21 Aug 2019 10:25:40 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <28723.1565882573@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/16/19 12:22 AM, Tom Lane wrote:
> Stephen Frost <sfrost@snowman.net> writes:
>> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>>> In hopes of moving this along, I've pushed Ian's last code change,
>>> as there seems to be no real argument about that anymore.
>>>
>>> As for the doc changes, how about the attached revision of what
>>> I wrote previously?  It gives some passing mention to what ALTER
>>> SYSTEM will do, without belaboring it or going into things that
>>> are really implementation details.
> 
>> It's certainly better than what we have now.
> 
> Hearing no other comments, I've pushed that and marked this issue closed.

Thanks!


Regards

Ian Barwick


-- 
  Ian Barwick                   https://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services