Subject: Re: Allow CURRENT_ROLE in GRANTED BY
To: Simon Riggs <simon@2ndquadrant.com>
References: <f2feac44-b4c5-f38f-3699-2851d6a76dc9@2ndquadrant.com>
 <f3723966-022a-fb74-06f4-3801f4fb7c1b@postgresfriends.org>
 <e9571f93-d04f-8357-7191-cc44df4a3a9a@2ndquadrant.com>
 <2073b6a9-7f79-5a00-5f26-cd19589a52c7@2ndquadrant.com>
 <CANP8+j+vJHt+RBLfFDFhiot1oe9yH0Lhs3tZ3htTtNYjYtzpJg@mail.gmail.com>
Cc: Vik Fearing <vik@postgresfriends.org>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <b720a227-3df7-c23e-79e7-61a89eade34e@2ndquadrant.com>
Date: Sat, 30 Jan 2021 09:51:03 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CANP8+j+vJHt+RBLfFDFhiot1oe9yH0Lhs3tZ3htTtNYjYtzpJg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-12-30 13:43, Simon Riggs wrote:
> On Thu, 10 Dec 2020 at 18:40, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> On 2020-06-24 20:21, Peter Eisentraut wrote:
>>> On 2020-06-24 10:12, Vik Fearing wrote:
>>>> On 6/24/20 8:35 AM, Peter Eisentraut wrote:
>>>>> I was checking some loose ends in SQL conformance, when I noticed: We
>>>>> support GRANT role ... GRANTED BY CURRENT_USER, but we don't support
>>>>> CURRENT_ROLE in that place, even though in PostgreSQL they are
>>>>> equivalent.  Here is a trivial patch to add that.
>>>>
>>>>
>>>> The only thing that isn't dead-obvious about this patch is the commit
>>>> message says "[PATCH 1/2]".  What is in the other part?
>>>
>>> Hehe.  The second patch is some in-progress work to add the GRANTED BY
>>> clause to the regular GRANT command.  More on that perhaps at a later date.
>>
>> Here is the highly anticipated and quite underwhelming second part of
>> this patch set.
> 
> Looks great, but no test to confirm it works. I would suggest adding a
> test and committing directly since I don't see any cause for further
> discussion.

Committed with some tests.  Thanks.

-- 
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/